Skip to content

Conversation

@xana-rahmani
Copy link

@xana-rahmani xana-rahmani commented Jul 26, 2025

Description

This pull request introduces import remappings for OpenZeppelin contracts to the remappings.txt file.

@xana-rahmani xana-rahmani changed the title feat(config): add openzeppelin remappings for cleaner imports Add OpenZeppelin remappings for improved developer experience Jul 26, 2025
@galekseev
Copy link
Member

Remappings are temporary solutions. We're removing them in the future.
There is no need in open zeppelin libraries mapping.

@galekseev galekseev closed this Aug 1, 2025
@galekseev galekseev reopened this Aug 21, 2025
@xana-rahmani
Copy link
Author

Hi @galekseev
Thanks for reopening this PR. I understand that the team is planning to move away from remappings in the future. However, I believe merging this change in the meantime would be beneficial for anyone reading the code, as it resolves errors in IDEs and improves overall readability.
This is a straightforward change that can be easily removed when the planned future refactoring takes place.

Thank you for your consideration.

@galekseev
Copy link
Member

After internal discussion we decided to close PR without merging.
The issue with openzepplin libraries mapping is solved with forge install command without adding additional remappings.
In PR #141 the command is implemented through postinstall task in package.json which also is called with yarn.
So it is enough to call yarn after downloading the clean repo.

@galekseev galekseev closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants