fix(fusion-order): accept chainId for getOrderHash method (#68)

1inch · Mar 20, 2024 · 8c3951f · 8c3951f
1 parent 4db61a7
commit 8c3951f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -28,7 +28,7 @@
     },
     "dependencies": {
         "@1inch/byte-utils": "2.2.0",
-        "@1inch/limit-order-sdk": "4.2.0",
+        "@1inch/limit-order-sdk": "4.5.0",
         "@metamask/eth-sig-util": "^5.0.2",
         "bn.js": "^5.2.1",
         "ethers": "6.11.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/fusion-order/fusion-order.ts b/src/fusion-order/fusion-order.ts
@@ -298,8 +298,8 @@ export class FusionOrder {
         return this.inner.build()
     }
 
-    public getOrderHash(domain = getLimitOrderV4Domain(1)): string {
-        return this.inner.getOrderHash(domain)
+    public getOrderHash(chainId: number): string {
+        return this.inner.getOrderHash(chainId)
     }
 
     public getTypedData(domain = getLimitOrderV4Domain(1)): EIP712TypedData {

diff --git a/src/sdk/sdk.ts b/src/sdk/sdk.ts
@@ -124,8 +124,7 @@ export class FusionSDK {
             allowMultipleFills: params.allowMultipleFills
         })
 
-        const domain = getLimitOrderV4Domain(this.config.network)
-        const hash = order.getOrderHash(domain)
+        const hash = order.getOrderHash(this.config.network)
 
         return {order, hash, quoteId: quote.quoteId}
     }
@@ -158,7 +157,7 @@ export class FusionSDK {
             order: orderStruct,
             signature,
             quoteId,
-            orderHash: order.getOrderHash(domain)
+            orderHash: order.getOrderHash(this.config.network)
         }
     }