Skip to content

Implement pre- and post-interactions in assembly #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement pre- and post-interactions in assembly #212

wants to merge 2 commits into from

Conversation

@k06a
Copy link
Member

@k06a k06a commented Feb 15, 2023

Wait but why?

··························|·············|·············|··············|················
|  Method                 ·  Min        ·  Max        ·  Avg         ·  # calls      │
··························|·············|·············|··············|················
|  cancelOrder            ·      44181  ·      44598  ·       44510  ·            6  │
··························|·············|·············|··············|················
|  fillContractOrder      ·      79586  ·      96686  ·       88136  ·            2  │
··························|·············|·············|··············|················
|  fillOrder              ·      81460  ·     118898  ·       99702  ·           26  │
··························|·············|·············|··············|················
|  fillOrderExt           ·      73765  ·     130636  ·      103601  ·           17  │
··························|·············|·············|··············|················
|  fillOrderToWithPermit  ·     127142  ·     127200  ·      127171  ·            4  │
··························|·············|·············|··············|················

=>

··························|·············|·············|··············|················
|  Method                 ·  Min        ·  Max        ·  Avg         ·  # calls      │
··························|·············|·············|··············|················
|  cancelOrder            ·      44178  ·      44595  ·       44507  ·            6  │
··························|·············|·············|··············|················
|  fillContractOrder      ·      79684  ·      96784  ·       88234  ·            2  │
··························|·············|·············|··············|················
|  fillOrder              ·      81515  ·     118960  ·       99759  ·           26  │
··························|·············|·············|··············|················
|  fillOrderExt           ·      73818  ·     130234  ·      103668  ·           17  │
··························|·············|·············|··············|················
|  fillOrderToWithPermit  ·     127138  ·     127196  ·      127167  ·            4  │
··························|·············|·············|··············|················

@k06a k06a requested a review from ZumZoom February 15, 2023 21:29
Base automatically changed from feature/rfq-extension to develop February 20, 2023 16:20
Base automatically changed from develop to master February 28, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZumZoom ZumZoom Awaiting requested review from ZumZoom

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@k06a @ZumZoom