Skip to content

Add magic salt to skip invalidation #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add magic salt to skip invalidation #32

wants to merge 4 commits into from

Conversation

@k06a
Copy link
Member

@k06a k06a commented Jun 18, 2021

No description provided.

@k06a k06a requested a review from ZumZoom June 18, 2021 12:59
@coveralls
Copy link

coveralls commented Jun 18, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1277059795

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 77.885%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/LimitOrderProtocol.sol 4 5 80.0%
Totals Coverage Status
Change from base Build 1277056755: -0.7%
Covered Lines: 159
Relevant Lines: 184
💛 - Coveralls

@ZumZoom ZumZoom changed the title Add magic salt to skip invalidation and allow only transferFrom selector Add magic salt to skip invalidation Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZumZoom ZumZoom Awaiting requested review from ZumZoom

1 more reviewer

@Ogruj098 Ogruj098 Ogruj098 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@k06a @coveralls @Ogruj098 @ZumZoom