Skip to content

Document view usage to avoid breaking overrides #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document view usage to avoid breaking overrides #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contracts/extensions/FeeTaker.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ contract FeeTaker is IPostInteraction, AmountGetterWithFee, Ownable {
/**
* @dev Parses fee data from `extraData`.
* Override this function if whitelist structure in postInteraction is different from getters.
* Kept as view since some inheriting contracts (e.g. Fusion Settlement) use state like block.timestamp.
*/
function _isWhitelistedPostInteractionImpl(bytes calldata whitelistData, address taker) internal view virtual returns (bool isWhitelisted, bytes calldata tail) {
return _isWhitelistedGetterImpl(whitelistData, taker);
Expand Down
Loading