Skip to content

Conversation

@Sunnesoft
Copy link
Contributor

Change Summary

What does this PR change?
Added Makefile for automatic deployments.
Optimized deployment scripts.

Testing & Verification

How was this tested?

  • Unit tests
  • Integration tests
  • Manual testing (verified Makefile targets with/without variables)
  • Verified on staging

Risk Assessment

Risk Level:

  • Low - Minor changes, no operational impact
  • Medium - Moderate changes, limited impact, standard rollback available
  • High - Significant changes, potential operational impact, complex rollback

Risks & Impact
These changes only affect Makefile logic for target execution and do not impact deployment or operational processes. No operational risks.

@Sunnesoft Sunnesoft requested a review from Copilot September 12, 2025 16:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds automation deployment capabilities by introducing a comprehensive Makefile for streamlined contract deployments and refactoring deployment scripts to use centralized constants. The changes enable flexible deployment methods (create vs create3) and support environment-specific configurations.

  • Added Makefile with validation, deployment automation, and environment management
  • Refactored deployment scripts to use centralized constants for addresses across multiple networks
  • Enhanced deployment methods to support both standard and create3 deployments with network-specific logic

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
hardhat.config.js Added deployOpts configuration for LOP helper names and deployment method
deploy/deploy.js Replaced hardcoded WETH addresses with constants and improved network validation
deploy/deploy-helpers.js Completely refactored to support dynamic helper deployment with create3/standard methods
deploy/deploy-fee-taker.js New deployment script for FeeTaker with create3 support and network validation
deploy/constants/*.js Added centralized constants files for WETH, router, access token, and create3 deployer addresses
Makefile Comprehensive automation script with deployment targets, validation, and environment management

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Sunnesoft Sunnesoft requested a review from Copilot September 12, 2025 16:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Sunnesoft Sunnesoft requested a review from zZoMROT September 29, 2025 12:28
@Sunnesoft Sunnesoft changed the title [PT1-93][PT1-94][PT1-139] Added automation deployment [PT1-93][PT1-94][PT1-139][PT1-172] Added automation deployment Sep 29, 2025
@Sunnesoft Sunnesoft changed the base branch from master to fix/native-order-zkSync September 29, 2025 12:37
@Sunnesoft Sunnesoft changed the base branch from fix/native-order-zkSync to deploy/native-order September 29, 2025 12:38
Base automatically changed from deploy/native-order to feature/new-eth-orders September 30, 2025 10:33
Base automatically changed from feature/new-eth-orders to master October 1, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant