-
Notifications
You must be signed in to change notification settings - Fork 157
[PT1-93][PT1-94][PT1-139][PT1-172] Added automation deployment #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds automation deployment capabilities by introducing a comprehensive Makefile for streamlined contract deployments and refactoring deployment scripts to use centralized constants. The changes enable flexible deployment methods (create vs create3) and support environment-specific configurations.
- Added Makefile with validation, deployment automation, and environment management
- Refactored deployment scripts to use centralized constants for addresses across multiple networks
- Enhanced deployment methods to support both standard and create3 deployments with network-specific logic
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| hardhat.config.js | Added deployOpts configuration for LOP helper names and deployment method |
| deploy/deploy.js | Replaced hardcoded WETH addresses with constants and improved network validation |
| deploy/deploy-helpers.js | Completely refactored to support dynamic helper deployment with create3/standard methods |
| deploy/deploy-fee-taker.js | New deployment script for FeeTaker with create3 support and network validation |
| deploy/constants/*.js | Added centralized constants files for WETH, router, access token, and create3 deployer addresses |
| Makefile | Comprehensive automation script with deployment targets, validation, and environment management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Change Summary
What does this PR change?
Added Makefile for automatic deployments.
Optimized deployment scripts.
Testing & Verification
How was this tested?
Risk Assessment
Risk Level:
Risks & Impact
These changes only affect Makefile logic for target execution and do not impact deployment or operational processes. No operational risks.