Skip to content

Feat/taker traits #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2025
Merged

Feat/taker traits #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bef219c
feat(PT4-566): adjust taker traits
rharutyunyan Nov 16, 2025
5bd8223
feat(PT3-566): adjustments in taker traits
rharutyunyan Nov 16, 2025
a14f68f
chore: rename `to` to `customReceiver`
vbrvk Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions typescript/swap-vm/src/swap-vm-contract/swap-vm-contract.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ describe('SwapVMContract', () => {
program: mockProgram,
})

const takerTraits = TakerTraits.fromParams({
isExactIn: true,
const takerTraits = TakerTraits.new({
exactIn: true,
threshold: 1000000n,
})

Expand Down Expand Up @@ -48,8 +48,8 @@ describe('SwapVMContract', () => {
program: mockProgram,
})

const takerTraits = TakerTraits.fromParams({
isExactIn: true,
const takerTraits = TakerTraits.new({
exactIn: true,
threshold: 1000000n,
})

Expand All @@ -73,9 +73,9 @@ describe('SwapVMContract', () => {
program: mockProgram,
})

const takerTraits = TakerTraits.fromParams({
isExactIn: true,
shouldUnwrapWeth: true,
const takerTraits = TakerTraits.new({
exactIn: true,
shouldUnwrap: true,
})

const takerData = new HexString('0xcafebabe')
Expand Down
1 change: 0 additions & 1 deletion typescript/swap-vm/src/swap-vm/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
export * from './maker-traits'
export * from './taker-traits'
export * from './order'
export * from './types'
export * from './programs'
export * from './instructions'
export * from './strategies'
2 changes: 1 addition & 1 deletion typescript/swap-vm/src/swap-vm/maker-traits.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ export class MakerTraits {
(acc, hookName, i) => {
const hook = this[hookName]
const hasTarget = this.hasTargetForHook(hookName)
const encoded = hook && hasTarget ? hook.encode() : hook?.data || HexString.EMPTY
const encoded = hook && hasTarget ? hook.encode() : (hook?.data || HexString.EMPTY)

acc.sum += BigInt(encoded.bytesCount())
acc.offsets += acc.sum << (16n * BigInt(i))
Expand Down
Loading
Loading