-
Notifications
You must be signed in to change notification settings - Fork 2
feat(PT3-497): debug opcodes #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrvk
reviewed
Nov 11, 2025
| export class ProgramBuilder { | ||
| protected program: IInstruction<IArgsData>[] = [] | ||
|
|
||
| public constructor(private readonly ixsSet: IOpcode[]) {} |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better make this protected and remove getter
vbrvk
added a commit
that referenced
this pull request
Nov 11, 2025
* fix(PT3-497): structure * chore: contracts * feat(PT3-497): rename shared to sdk-core, add some comments on funcitons which throw an error * fic: comment * feat(PT3-497): debug opcodes (#7) * feat(PT3-497): debug opcodes * feat: debug opcodes * feat(PT3-497): opcodes debug * feat(PT3-497): Debug opcodes in program builders * chore: eslint * fix: comment * feat: architecture change * fix: remappings * chore * Update swap-vm.spec.ts --------- Co-authored-by: Vladimir Borovik <[email protected]>
vbrvk
added a commit
that referenced
this pull request
Nov 11, 2025
* chore: add foundry and aqua contracts * feat: fix build * feat: setup e2e tests * wip * wip * wip * chore: add opcodes mvp * chore: add test aqua app/trader * feat: program, instructions, opcodes * chore: refactor * chore: cleanup * cleanup * chore: cleanup * feat: PT3-497 add controls opcodes, instructions * feat(PT3-497): add invalidator opcodes, instructions, tests * feat(PT3-497): add more opcodes, decay, concentrate, xyc swap * feat(PT3-497): add final opcodes and instructions * fix(PT3-497): fix tests clean up lint * fix(PT3-497): fix decoding and encdoging of opcodes * feat:(PT3-497): tests * wip * fix(PT3-497); fix tests * wip * feat: first working test * feat: swap test * chore: dock e2e test * Update aqua.spec.ts * feat: pull/push tests * Update aqua.spec.ts * fix(PT3-497): replace iter.HexString to iter.BigInt in some places * cleanup: remove pull/push * cleanup: do not insert empty tx as first instruction * fix: comments * fix: cleanup * Update swap-vm-program.ts * feat(PT3-497): update opcodes, fix some comments * wip * fix: linter * chore: swap vm e2e tests setup * chore: clenup strategy * cleanup * chore * chore: e2e test for AquaAMM * chore * custom vm tests wip * Fix/structure (#6) * fix(PT3-497): structure * chore: contracts * feat(PT3-497): rename shared to sdk-core, add some comments on funcitons which throw an error * fic: comment * feat(PT3-497): debug opcodes (#7) * feat(PT3-497): debug opcodes * feat: debug opcodes * feat(PT3-497): opcodes debug * feat(PT3-497): Debug opcodes in program builders * chore: eslint * fix: comment * feat: architecture change * fix: remappings * chore * Update swap-vm.spec.ts --------- Co-authored-by: Vladimir Borovik <[email protected]> --------- Co-authored-by: rharutyunyan <[email protected]> Co-authored-by: Radik Harutyunyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What does this PR change?
Related Issue/Ticket:
https://1inch.atlassian.net/browse/PT3-497
Testing & Verification
How was this tested?
Risk Assessment
Risk Level:
Risks & Impact