Skip to content

Conversation

@rharutyunyan
Copy link
Contributor

@rharutyunyan rharutyunyan commented Nov 11, 2025

Change Summary

What does this PR change?

Related Issue/Ticket:
https://1inch.atlassian.net/browse/PT3-497

Testing & Verification

How was this tested?

  • Unit tests
  • Integration tests
  • Manual testing (describe steps)
  • Verified on staging

Risk Assessment

Risk Level:

  • Low - Minor changes, no operational impact
  • Medium - Moderate changes, limited impact, standard rollback available
  • High - Significant changes, potential operational impact, complex rollback

Risks & Impact

export class ProgramBuilder {
protected program: IInstruction<IArgsData>[] = []

public constructor(private readonly ixsSet: IOpcode[]) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better make this protected and remove getter

@rharutyunyan rharutyunyan merged commit 8f7b5f2 into fix/structure Nov 11, 2025
1 check failed
@rharutyunyan rharutyunyan deleted the feat/debug-opcodes branch November 11, 2025 12:43
vbrvk added a commit that referenced this pull request Nov 11, 2025
* fix(PT3-497): structure

* chore: contracts

* feat(PT3-497): rename shared to sdk-core, add some comments on funcitons which throw an error

* fic: comment

* feat(PT3-497): debug opcodes (#7)

* feat(PT3-497): debug opcodes

* feat: debug opcodes

* feat(PT3-497): opcodes debug

* feat(PT3-497): Debug opcodes in program builders

* chore: eslint

* fix: comment

* feat: architecture change

* fix: remappings

* chore

* Update swap-vm.spec.ts

---------

Co-authored-by: Vladimir Borovik <[email protected]>
vbrvk added a commit that referenced this pull request Nov 11, 2025
* chore: add foundry and aqua contracts

* feat: fix build

* feat: setup e2e tests

* wip

* wip

* wip

* chore: add opcodes mvp

* chore: add test aqua app/trader

* feat: program, instructions, opcodes

* chore: refactor

* chore: cleanup

* cleanup

* chore: cleanup

* feat: PT3-497 add controls opcodes, instructions

* feat(PT3-497): add invalidator opcodes, instructions, tests

* feat(PT3-497): add more opcodes, decay, concentrate, xyc swap

* feat(PT3-497): add final opcodes and instructions

* fix(PT3-497): fix tests clean up lint

* fix(PT3-497): fix decoding and encdoging of opcodes

* feat:(PT3-497): tests

* wip

* fix(PT3-497); fix tests

* wip

* feat: first working test

* feat: swap test

* chore: dock e2e test

* Update aqua.spec.ts

* feat: pull/push tests

* Update aqua.spec.ts

* fix(PT3-497): replace iter.HexString to iter.BigInt in some places

* cleanup: remove pull/push

* cleanup: do not insert empty tx as first instruction

* fix: comments

* fix: cleanup

* Update swap-vm-program.ts

* feat(PT3-497): update opcodes, fix some comments

* wip

* fix: linter

* chore: swap vm e2e tests setup

* chore: clenup strategy

* cleanup

* chore

* chore: e2e test for AquaAMM

* chore

* custom vm tests wip

* Fix/structure (#6)

* fix(PT3-497): structure

* chore: contracts

* feat(PT3-497): rename shared to sdk-core, add some comments on funcitons which throw an error

* fic: comment

* feat(PT3-497): debug opcodes (#7)

* feat(PT3-497): debug opcodes

* feat: debug opcodes

* feat(PT3-497): opcodes debug

* feat(PT3-497): Debug opcodes in program builders

* chore: eslint

* fix: comment

* feat: architecture change

* fix: remappings

* chore

* Update swap-vm.spec.ts

---------

Co-authored-by: Vladimir Borovik <[email protected]>

---------

Co-authored-by: rharutyunyan <[email protected]>
Co-authored-by: Radik Harutyunyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants