Skip to content

Conversation

@zZoMROT
Copy link
Contributor

@zZoMROT zZoMROT commented Nov 4, 2024

Static Code Analysis (readability, compactness):

The utility is deprecated and no longer necessary. It's possible to replace it with a custom template for docgen.

Dynamic Code Analysis (external APIs, interaction flows):

  • The utility has been compromised by malicious actors who created a harmful npm package with the same name. This malicious package installs when the command is run without prior dependency installation, and, after installed, opens a shell to the host machine.
  • This PR removes the potential risk for developers to unintentionally compromise their own systems.

Efficiency (gas costs, computational complexity, memory requirements):

No changes affecting gas or resource efficiency.

Opinion, trade-offs and other thoughts (optional):

Looks like should be updated asap.

@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (7dab142) to head (e8db2eb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files          17       17           
  Lines         345      345           
  Branches       67       67           
=======================================
  Hits          322      322           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZumZoom ZumZoom merged commit 3c89708 into master Nov 5, 2024
8 checks passed
@ZumZoom ZumZoom deleted the docgen branch November 5, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants