Skip to content

Conversation

@zZoMROT
Copy link
Contributor

@zZoMROT zZoMROT commented Sep 18, 2025

Static Code Analysis (readability, compactness):

Replaces Etherscan API network keys with a single v2 key. Config is simpler and easier to maintain.

Dynamic Code Analysis (external APIs, interaction flows):

Switches verification to Etherscan API v2.
Breaking: requires a new unified env var ETHERSCAN_API_KEY for method registerAll() for the API V2 key. API V1 keys no longer work (Etherscan sunset).

Efficiency (gas costs, computational complexity, memory requirements):

No runtime impact, configuration-only change.

Opinion, trade-offs and other thoughts (optional):

Breaking in contract source verifications (and deploys with verification) but necessary.

@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (10927a4) to head (4cabb9e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          346       346           
  Branches        65        65           
=========================================
  Hits           346       346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@Sunnesoft Sunnesoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update hardhat packages to work with new etherscan API? Or its enough just to update API-key?

@zZoMROT
Copy link
Contributor Author

zZoMROT commented Sep 19, 2025

Do we need to update hardhat packages to work with new etherscan API? Or its enough just to update API-key?

For now it’s enough to just update the API key and etherscan: apiKey hardhat config

@zZoMROT zZoMROT requested a review from Sunnesoft September 19, 2025 08:06
@zZoMROT zZoMROT merged commit 2693fcd into master Sep 19, 2025
9 checks passed
@zZoMROT zZoMROT deleted the feature/update-etherscan-verification branch September 19, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants