Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZgatewaySERIAL.ino Fix tx issues #2131

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

mycprotein
Copy link

The serial gateway can only receive serial data and publish via mqtt, but can not convert mqtt into serial data. It is because the receiverReady is not handled correctly for the tx part. A quick work around is to set receiverReady to true. (it seems not used)

Description:

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

The serial gateway can only receive serial data and publish via mqtt, but can not convert mqtt into serial data. It is because the receiverReady is not handled correctly for the tx part. A quick work around is to set receiverReady to true. (it seems not used)
@1technophile
Copy link
Owner

Do you have SENDER_SERIAL_HEARTBEAT defined ?

@mycprotein
Copy link
Author

It is not mentioned in the header file, so I initially thought it was still under construction. I recommend updating and commenting on it in the header file. Otherwise, many users may struggle to understand and utilize the tx function effectively.

@1technophile
Copy link
Owner

We could condition bool receiverReady = true; to the non definition of macro SENDER_SERIAL_HEARTBEAT

@mycprotein
Copy link
Author

Sounds great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants