-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Limiter interface #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
k1LoW
commented
Oct 31, 2023
•
edited
Loading
edited
- Rename LimitError to Context.
- Accept Context straight away.
- Fix Context to retain the value of limitHandler at the time of
- Export Context fields for implementing Limiter
- Accept LimitError straight away. - Fix LimitError to retain the value of limitHandler at the time of - Export LimitError fields for creating Limiter
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
k1LoW
force-pushed
the
fix-limiter-interface
branch
from
October 31, 2023 02:11
15f6fda
to
d2295db
Compare
Code Metrics Report
Details | | main (c10a935) | #35 (c19212d) | +/- |
|---------------------|----------------|---------------|-------|
- | Coverage | 80.8% | 79.5% | -1.3% |
| Files | 2 | 2 | 0 |
| Lines | 78 | 73 | -5 |
- | Covered | 63 | 58 | -5 |
- | Code to Test Ratio | 1:0.9 | 1:0.9 | -0.0 |
| Code | 219 | 214 | -5 |
- | Test | 204 | 196 | -8 |
- | Test Execution Time | 16s | 18s | +2s | Code coverage of files in pull request scope (80.8% → 79.5%)
Reported by octocov |
This comment has been minimized.
This comment has been minimized.
BenchmarkRL-2
Metadata
Cachegrind (./testdata/testbin/testbin 10000)
Metadata
Reported by octocov |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.