[BUG/ticket] 성공/실패 요청 수 측정 오류 해결 #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khabh
approved these changes
Nov 22, 2024
Collaborator
khabh
left a comment
khabh
left a comment
There was a problem hiding this comment.
이제 요청 수 측정이 올바르게 되는 것 같네요 :)
제안 사항 하나 코멘트로 남겨 두었으니 확인해 주세요!
| } | ||
|
|
||
| private void sendMultipleRequests(ExecutorService executorService, List<Member> members, Ticket... tickets) { | ||
| private void sendMultipleRequests(Integer threadCount, List<Member> members, Ticket... tickets) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| private void sendMultipleRequests(Integer threadCount, List<Member> members, Ticket... tickets) { | |
| private void sendMultipleRequests(int ticketIssueCount, List<Member> members, Ticket... tickets) { |
Comment on lines
+111
to
+113
| try (ExecutorService executorService = Executors.newFixedThreadPool(threadCount)) { | ||
| for (Member member : members) { | ||
| for (int i = 0; i < MemberTicket.MEMBER_TICKET_COUNT_MAX; i++) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| try (ExecutorService executorService = Executors.newFixedThreadPool(threadCount)) { | |
| for (Member member : members) { | |
| for (int i = 0; i < MemberTicket.MEMBER_TICKET_COUNT_MAX; i++) { | |
| int threadCount = members.size() * ticketIssueCount; | |
| try (ExecutorService executorService = Executors.newFixedThreadPool(threadCount)) { | |
| for (Member member : members) { | |
| for (int i = 0; i < ticketIssueCount; i++) { |
Collaborator
There was a problem hiding this comment.
이런 식으로 수정해 보는 건 어떨까요? 멤버당_티켓_발급_제한을_초과하는_요청_시_정상_처리_여부를_검증한다 테스트에서 멤버 티켓 발급 제한을 초과하지 않고 있는 문제가 있습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #19 를 해결합니다.