Added Oracle adapters #72
Conversation
| public BooleanExpression crosses(ScalarExpression leftOperand, ScalarExpression rightOperand) { | ||
| // Oracle Database does not have a direct equivalent to PostgreSQL's st_crosses function. | ||
| // You may need to create a custom function or use a different approach. | ||
| throw new UnsupportedOperationException("crosses is not supported in Oracle Database."); |
There was a problem hiding this comment.
Could we use MDSYS.sdo_relate combined with the 'mask=OVERLAPBDYINTERSECT'?
| protected Column getGeometryType(Table geometryData) { | ||
| // Oracle Database does not have a direct equivalent to PostgreSQL's geometry_properties column. | ||
| // You may need to create a custom function or use a different approach. | ||
| throw new UnsupportedOperationException("getGeometryType is not supported in Oracle Database."); |
There was a problem hiding this comment.
The equivalent expression in Oracle looks like JSON_VALUE(geometry_properties, '$.type') ) . This is a Function expression rather than Column. We may need to change the API here.
|
I think it would be helpful for testing to add the CLI parameter databaseType in this PR. |
|
CityGML import/export work fine, but the import performance could be better. In my tests, importing untextured LOD2 buildings takes approx. 20s per 1000 buildings (with indexes disabled). The PostgreSQL version only needs 2 seconds. |
|
|
||
| @Override | ||
| public Function extent(ScalarExpression operand) { | ||
| return Function.of("sdo_mbr", operand); |
There was a problem hiding this comment.
We need to use sdo_aggr_mbr here, because the extent is calculated over a column (envelpe).
Added Oracle adapters.