Browser history control form server side #89
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svetlyak40wt
requested changes
Aug 13, 2025
| (let ((action-code (when pop-action | ||
| (etypecase pop-action | ||
| (string pop-action) | ||
| (function (reblocks/actions:make-action pop-action)))))) |
Member
There was a problem hiding this comment.
In the docstring to browser-history-push-state I think we should mention that an action will be called with two arguments location and state.
Also, I'd prefer state argument of the browser-history-push-state to be a hash-table, but not sure if it will be deserialized into a hash-table propertly when action us called by the frontend.
Contributor
Author
|
Thanks for the comments. I'll apply. I'm not sure yet if I will deliver this like this, or as separate module in my reblocks-extras repository. |
Member
Anyway, your idea seems very interesting to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to be able to control browser history from server side in ajax requests/components.
For example, I use this in an ajax pagination controller, to change the current page in the browser:
(history-push-state "?page=30")