Simpler deploy of patch releases #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-veit
commented
Sep 26, 2022
| @@ -21,5 +21,6 @@ jobs: | |||
| - name: Docs | |||
| env: | |||
| DOCS_TOKEN: ${{ secrets.DOCS_TOKEN }} | |||
| TIBANNA_VERSION: 2.2.0 | |||
There was a problem hiding this comment.
The docs-deploy GA does not work anymore. I think that's because it can't determine the version, since it is now parsed from pyproject.toml. One solution would be to set the env variable here. Not elegant at all, but I am not sure how to get it otherwise.
I had the same issue with the Lambda function and solved it there via env variables.
alexander-veit
commented
Sep 26, 2022
| @@ -21,3 +22,7 @@ def _get_project_meta(): | |||
| # they can't parse the pyproject.toml. For all other use cases, fall back to the pyproject.toml version | |||
| __version__ = os.environ.get('TIBANNA_VERSION', False) or str(pkg_meta['version']) | |||
|
|
|||
| # AWSF image version - will default to the minor version of the deployed Tibanna | |||
| tibanna_version = semantic_version.Version(__version__) | |||
| __awsf_image_version__ = str(semantic_version.Version(major=tibanna_version.major, minor=tibanna_version.minor, patch=0)) | |||
There was a problem hiding this comment.
I would import __awsf_image_version__ into tibanna_ff as we do with __version__ to bring that change to CGAP.
willronchetti
approved these changes
Sep 26, 2022
| @@ -21,5 +21,6 @@ jobs: | |||
| - name: Docs | |||
| env: | |||
| DOCS_TOKEN: ${{ secrets.DOCS_TOKEN }} | |||
| TIBANNA_VERSION: 2.2.0 | |||
There was a problem hiding this comment.
This version won't matter for the docs build though right?
There was a problem hiding this comment.
I think the version matters. It is also used in the conf.py in the docs folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be helpful, if the release of patches was simpler.
I suggest that the AWSF image defaults to the minor version of the deployed Tibanna. E.g. if Tibanna version 2.1.1 is deployed, the default AWSF image is 2.1.0. The advantage would be that patch releases only require a redeploy of Tibanna but not a new docker image. If the docker image required changes, it should be a minor release anyway.