Skip to content

Conversation

keul
Copy link
Contributor

@keul keul commented May 5, 2015

Mainly i18n changes:

  • italian translation
  • i18ndude script added
  • removed needs of manual translations
  • removed german messages from templated and needs of "en" translation folder

Other changes:

  • re-enabled the "view" tab (not sure why it was disabled)
  • Now use DataGridField 1.9+, with new features like required column value, column description. I was also planning to require 1.9.1+ where DateColumn has been added but there's no real change in the UI right now (PR Datecolumn collective/Products.DataGridField#15 is not merged)

@jone
Copy link
Member

jone commented May 6, 2015

Hey, thanks for your work!

It looks good, I'll update the German translations after merging.

Just a note on the runi18ndude.sh script:
We usually have development.cfg creating a bin/i18n-build script.
The development.cfg was missing, I've added it to master.
So I'll remove your script after merging so that we can follow our company policy 😉

I also discovered that the required in the DataGridField is not very handy in combination with auto_insert=True: an empty line is always automatically inserted, leading to a validation error:
bildschirmfoto 2015-05-06 um 09 51 49
I'll remove the auto_insert flag.

jone added a commit that referenced this pull request May 6, 2015
i18n fixes and italian translation
@jone jone merged commit 5da92a7 into 4teamwork:master May 6, 2015
@jone
Copy link
Member

jone commented May 6, 2015

I've released ftw.poodle = 1.5.0 with your changes.

@keul keul deleted the i18n-it branch May 6, 2015 09:19
@keul
Copy link
Contributor Author

keul commented May 6, 2015

@jone thanks!
About the issue with DataGridField required + autoinsert, I will open an issue there, maybe I will try to fix it in future.

@jone
Copy link
Member

jone commented May 6, 2015

ok thanks!
auto-insert is disabled in ftw.poodle = 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants