SafetySettings invalid arguments #2008
Draft
+65
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter out HARM_CATEGORY_IMAGE_* defensively to avoid 400 INVALID_ARGUMENT errors from Google GenAI (issue #1773). Adds a regression test to ensure IMAGE categories never get sent. Co-authored-by: jason <[email protected]>
Moves the IMAGE harm category regression test out of llm-only GenAI tests so it runs without GOOGLE_API_KEY. Guards against sending HARM_CATEGORY_IMAGE_* in safety_settings (issue #1773). Co-authored-by: jason <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
instructor | cb54f34 | Commit Preview URL Branch Preview URL |
Jan 16 2026, 05:35 PM |
github-actions
bot
added
bug
Collaborator
Author
|
@cursoragent fix the ci issues |
|
CI’s Ruff job was failing because
|
Apply Ruff formatting to keep CI green. Co-authored-by: jason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: filter Google GenAI HARM_CATEGORY_IMAGE_* to prevent 400 INVALID_ARGUMENT
Describe your changes
This PR resolves a critical production blocker where Google GenAI's
generateContentendpoint would return400 INVALID_ARGUMENTerrors whensafety_settingsincludedHARM_CATEGORY_IMAGE_*categories, especially with multimodal requests.The fix defensively filters out all
HARM_CATEGORY_IMAGE_*categories from thesafety_settingsbefore they are sent to the Google GenAI API. A new regression test ensures these categories are never included, even if provided by the user. This prevents the API from rejecting valid requests due to unsupported safety settings.Issue ticket number and link
Linear: 567-264
GitHub: #1773
Checklist before requesting a review
Linear Issue: 567-264