Skip to content

use MFA config of SourceProfile #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use MFA config of SourceProfile #1250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions vault/vault.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,21 +313,21 @@ func (t *TempCredentialsCreator) canUseGetSessionToken(c *ProfileConfig) (bool,
return false, "sessions are disabled for this profile"
}

if c.IsChained() {
if !c.ChainedFromProfile.HasMfaSerial() {
return false, fmt.Sprintf("profile '%s' has no MFA serial defined", c.ChainedFromProfile.ProfileName)
if c.HasSourceProfile() {
if !c.SourceProfile.HasMfaSerial() {
return false, fmt.Sprintf("profile '%s' has no MFA serial defined", c.SourceProfile.ProfileName)
}

if !c.HasMfaSerial() && c.ChainedFromProfile.HasMfaSerial() {
if !c.HasMfaSerial() && c.SourceProfile.HasMfaSerial() {
return false, fmt.Sprintf("profile '%s' has no MFA serial defined", c.ProfileName)
}

if c.ChainedFromProfile.MfaSerial != c.MfaSerial {
return false, fmt.Sprintf("MFA serial doesn't match profile '%s'", c.ChainedFromProfile.ProfileName)
if c.SourceProfile.MfaSerial != c.MfaSerial {
return false, fmt.Sprintf("MFA serial doesn't match profile '%s'", c.SourceProfile.ProfileName)
}

if c.ChainedFromProfile.AssumeRoleDuration > roleChainingMaximumDuration {
return false, fmt.Sprintf("duration %s in profile '%s' is greater than the AWS maximum %s for chaining MFA", c.ChainedFromProfile.AssumeRoleDuration, c.ChainedFromProfile.ProfileName, roleChainingMaximumDuration)
if c.SourceProfile.AssumeRoleDuration > roleChainingMaximumDuration {
return false, fmt.Sprintf("duration %s in profile '%s' is greater than the AWS maximum %s for chaining MFA", c.SourceProfile.AssumeRoleDuration, c.SourceProfile.ProfileName, roleChainingMaximumDuration)
}
}

Expand Down