Fixes numerous issues when using oneAPI #34
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ag -ip, add -qno-opt-dynamic-align flag
…eems to be not compiled currrently)
|
I have confirmed that the library builds on gadi using |
|
@CodeGat The CI is failing and I need to see the |
|
@CodeGat Sorry - I haven't had any time to figure out how to access that log. Is there an "easy" way for you to do it? |
|
Noting that the updates to build-ci fixed the broken build, and the logs are no longer required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gadi(withinbuild.sh)openmpi/5.0.5andnetcdf/4.9.2(withinbuild.sh)llvm-arby default (in preparation for using-fltodown the track, whenllvm-arwill be necessary but no drawbacks from what I can tell for now)-ip-qno-opt-dynamic-alignfor removing one possible avenue for non-deterministic resultscqas the archiver flags formct/Makefileandmpeu/Makefile- unclear to me whyscrip/Makefileuses$ARFLAGSbut these two don't. Hardcoding the flags preserves previous behaviour. See Inconsistencies with using ARFLAGS when creating static libraries #31get_zeits.c) #33 (which turned out to be because of the old-style function definition - the prototypes were present)configureandconfigure.acwhere it checks for mismatched arguments. Not sure whyconfigurethought that the flags were supported and kept adding them in the compile flags, but the compiler (ifx) does not support them.Fixes #26, #30, #33