ci: update actions to pinned SHA numbers#717
Closed
andrewb1269 wants to merge 6 commits intoACINQ:masterfrom
Closed
ci: update actions to pinned SHA numbers#717andrewb1269 wants to merge 6 commits intoACINQ:masterfrom
andrewb1269 wants to merge 6 commits intoACINQ:masterfrom
Conversation
**Description**: Update the actions in the `testnet-build.yml` file to pinned commit SHAs. **Related Issue(s)**: Fixes ACINQ#716 Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
dpad85
requested changes
Jun 6, 2025
Member
There was a problem hiding this comment.
Thanks for making this PR. The changes in the github action look good (though note that this action builds a testnet version of Phoenix, not the mainnet one).
About Dependabot : dependabot alerts are already enabled in the repository and I think that's sufficient. I don't think we need Dependabot to open Pull Requests as well. If there is a problem we'll fix it manually. Can you remove the dependabot.yml configuration file?
Signed-off-by: Andrew Brandt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update the actions in the
testnet-build.ymlfile to pinned commit SHAs.The following actions were updated to the latest version:
actions/checkoutpreviouslyv2, nowv4.2.2The following actions were NOT updated:
actions/cachepreviouslyv4, nowv4.2.3actions/setup-javapreviouslyv1, nowv1.4.4actions/upload-artifactpreviouslyv4, nowv4.6.2Also I've added the config file for dependabot in
dependabot.yml. The maintainers of this repo will need to enable dependabot:SettingsTab >Security>Advanced Security> Enable Dependabot.Related Issue(s):
Fixes #716