Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Profile Dropdown #109

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: Profile Dropdown #109

wants to merge 15 commits into from

Conversation

RuikangRPI
Copy link
Contributor

  • working rotating profile dropdown django component
  • implemented into navbar
  • navbar mobile compatibility
  • responsive breakpoints: change from rotating dropdown to normal dropdown

RuikangRPI and others added 11 commits October 27, 2023 22:21
@RuikangRPI
profile dropdown
edf258f 
To be implemented as a django component.
@RuikangRPI
feat: rotating profile dropdown
d5ded18 
- added script to _base.html
- added profile dropdown
- need to add on hover effects for the icons
@RuikangRPI
Merge remote-tracking branch 'origin/template-redesigns' into profile…
bd55ada 
…_dropdown
@RuikangRPI
Merge remote-tracking branch 'origin/template-redesigns' into profile…
dc5ffc0 
…_dropdown
@RuikangRPI
polish nav and dropdown
b8b8128
@RuikangRPI
nav fix
af14527
@RuikangRPI
complete navbar
51b465b 
mobile compatibility: responsive breakpoints and dropdown for user menu in mobile sizing.
@RuikangRPI
hover color change
d950d33
@RuikangRPI
Merge branch 'main' into profile_dropdown
15cd68d
@RuikangRPI
Ignore & Remove DS_Store
8591e04
@RuikangRPI
lint fix
ca1af83
noahcussatti
noahcussatti approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@noahcussatti noahcussatti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You should wait for @jaw12346 's approval before merging.

@jaw12346
Copy link
Member

Please pin navbar elements to a side. It looks a little funky being offset like this.
image

@jaw12346
Copy link
Member

What's the idea behind the "settings" button? It doesn't do anything even as admin, so it might be worth removing for non-admin users and keeping it for admin users as a link to the django admin page
image

jaw12346
jaw12346 requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@jaw12346 jaw12346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please respond to my comments before I approve.

@RuikangRPI
Copy link
Contributor Author

Please pin navbar elements to a side. It looks a little funky being offset like this.
image

Pinned Navbar
Screenshot 2023-12-05 at 4 54 14 PM

@RuikangRPI
Copy link
Contributor Author

What's the idea behind the "settings" button? It doesn't do anything even as admin, so it might be worth removing for non-admin users and keeping it for admin users as a link to the django admin page
image

Light/Dark Mode Toggle Button - Icon switches onclick
Screenshot 2023-12-05 at 5 12 16 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaw12346 jaw12346 jaw12346 requested changes

@noahcussatti noahcussatti noahcussatti approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RuikangRPI @jaw12346 @noahcussatti