-
Notifications
You must be signed in to change notification settings - Fork 1
Add support for diagonal asymptotics in non-smooth cases #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments so far are mostly about documentation. I still need to review the "interesting" part of the code in asymptotics.py
and whitney.py
in detail; more comments following later. Looking good so far!
…binatorial returning wrong number of points
…s of exponential terms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed some (hopefully) uncontroversial improvements in 7338dbe, 72121a7, 80f5ed8, b0ae16d -- and am now done with this branch.
There are two larger suggestions that I think would make sense to include, namely:
- refactoring
diagonal_asy_smooth
and turning it into a private function (->_diagonal_asy_smooth
) while moving the doctests to the new and improveddiagonal_asy
. I'd be more comfortable to modify the interface some more, which would allow reusing more code fromdiagonal_asy
(like castingr
, the rational splitting, ...) -- so effectively, to call_diagonal_asy_smooth
a bit later. - And second, I feel it would also be a good time to remove the deprecated
as_symbolic
keyword argument.
If you agree, I'd take care of both of these in follow-up PRs though, as I'd really like to get this merged now.
Pretty cool stuff! 🚀
No description provided.