Add helper function to extract coefficients of powers of n #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behackl
requested changes
Mar 12, 2025
|
Thanks for the updates here! I'm in the middle of some finalizing (mostly cosmetic) changes, will finish this first thing tomorrow morning. |
behackl
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Well, the changes got increasingly non-cosmetic towards the end, but I'm now very happy with this. Check the examples in the docstrings!
I'll approve this PR now, could you perhaps cross-check my changes @turnip314?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@behackl @smelczer Helper function that separates an ACSV output (of any format) into a dictionary which maps the degree of the power of
nterm to its coefficients (see doctest for example). This way if users only care about the last part (with the expansion terms) they can just pass the last element of the tuple.