Skip to content

M2 interfaces to some functions #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 14, 2025
Merged

M2 interfaces to some functions #23

merged 9 commits into from
Mar 14, 2025

Conversation

turnip314
Copy link
Collaborator

@turnip314 turnip314 commented Mar 12, 2025

Includes PrimaryDecomposition, Saturate, GroebnerBasis, and Radical. Will use M2 if available (will need to integrate this with ACSVSettings).

Note: M2 is picky and doesn't like certain characters in their variable names, so the workaround for now is to convert it to a new ring with basic variable names x0, x1, ..., then convert it back after.

EDIT: tests will probably fail because I'm currently manually loading m2 from my installation directory

@turnip314 turnip314 mentioned this pull request Mar 13, 2025
Copy link
Collaborator

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only read the changes, and did not locally test them -- but if this works for you (and apparently the tests still pass), I'm happy! Very nice, I like how the interface of the functions is now a little less messy! 🚀

Co-authored-by: Benjamin Hackl <[email protected]>
@turnip314 turnip314 merged commit ca62da0 into main Mar 14, 2025
5 checks passed
@behackl behackl deleted the ms-integration branch March 14, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants