Skip to content

Introduce consistent naming scheme across module #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 29, 2025
Merged

Conversation

behackl
Copy link
Collaborator

@behackl behackl commented Mar 28, 2025

This PR renames a lot of functions in our package to make sure that they follow a more consistent naming scheme.

Deprecation warnings are also introduced for core interface functions that appeared in the arXiv paper on the smooth case (in particular, diagonal_asy and kronecker).

@behackl
Copy link
Collaborator Author

behackl commented Mar 28, 2025

For the sake of convenience, I have used the abbreviation

sage: from sage_acsv import diagonal_asymptotics_diagonal as diagonal
sage: diagonal(1/(1 - x - y))

in case you dislike this, this change can be reverted easily. I have not touched anything in the paper/ directory.

@behackl behackl mentioned this pull request Mar 29, 2025
3 tasks
Copy link
Collaborator

@turnip314 turnip314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor changes. Main thing is maybe MinimalCriticalCombinatorial should also have a deprecation warning.

@behackl
Copy link
Collaborator Author

behackl commented Mar 29, 2025

Thanks for the review, @turnip314! I'm merging this now, I think this is now more or less safe to base further changes on without the risk of running into significant merge conflicts. :-)

@behackl behackl merged commit dfff5b3 into main Mar 29, 2025
5 checks passed
@behackl behackl deleted the name-changes branch March 29, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants