-
Notifications
You must be signed in to change notification settings - Fork 1
Introduce consistent naming scheme across module #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nal" in notebooks (clean, revertable on demand)
For the sake of convenience, I have used the abbreviation
in case you dislike this, this change can be reverted easily. I have not touched anything in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor changes. Main thing is maybe MinimalCriticalCombinatorial
should also have a deprecation warning.
Thanks for the review, @turnip314! I'm merging this now, I think this is now more or less safe to base further changes on without the risk of running into significant merge conflicts. :-) |
This PR renames a lot of functions in our package to make sure that they follow a more consistent naming scheme.
Deprecation warnings are also introduced for core interface functions that appeared in the arXiv paper on the smooth case (in particular,
diagonal_asy
andkronecker
).