[WIP] pandas -> arrow #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADBond
force-pushed
the
drop-pandas-for-arrow
branch
from
d12a5d9 to
6437a8d
Compare
ADBond
force-pushed
the
drop-pandas-for-arrow
branch
from
317b031 to
54e3d15
Compare
ADBond
force-pushed
the
drop-pandas-for-arrow
branch
from
54e3d15 to
c73963a
Compare
Owner
Author
|
Spark tests were failing with stricter typing in a slightly opaque way (failing at parsing a date as a timestamp). There is a workaround extending the custom SQL dialect code, but this is only really intended as a stopgap - ultimately i think some of the code around that area could do with a little reworking. |
Owner
Author
|
The finalised version of this PR is open to the main repo: moj-analytical-services#2883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3rd time lucky. Splink 5 only.
See #46 and #58 for a bit more context