Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a segfault when cleaning up resources #143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix a segfault when cleaning up resources #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef59045
Fix segfault in cleanup
r-owen May 26, 2020
bd958bf
Remove unneeded () from `class QoSPolicy`
r-owen May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/api/dcps/python/code/dds.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class DDSSampleRejectedStatusKind(Enum):
REJECTED_BY_SAMPLES_PER_INSTANCE_LIMIT = 3

# Basic Qos Policy class
class QosPolicy():
class QosPolicy:
'''
Abstract QoS policy class.
Users should not instantiate this class.
Expand Down Expand Up @@ -2995,12 +2995,6 @@ cdef class Condition:
def __cinit__(self):
self._c_handle = NULL

def __dealloc__(self):
if self._c_handle is not NULL:
with nogil:
dds_condition_delete(self._c_handle)
self._c_handle = NULL

cdef set_handle(self, dds_condition_t handle):
self._c_handle = handle

Expand Down