Skip to content

Conversation

@kriskd
Copy link

@kriskd kriskd commented Jun 25, 2024

@kriskd kriskd force-pushed the fix-schema-deprecation branch 2 times, most recently from 7bf1b36 to 81870da Compare June 25, 2024 18:40
@kriskd kriskd changed the base branch from master to 1.x June 25, 2024 18:48
@kriskd kriskd force-pushed the fix-schema-deprecation branch from 81870da to 20e7762 Compare June 25, 2024 18:52
@codecov
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.37%. Comparing base (495589f) to head (20e7762).

Current head 20e7762 differs from pull request most recent head 6f6b4b6

Please upload reports for the commit 6f6b4b6 to get more accurate results.

Files Patch % Lines
src/Middleware/SocialAuthMiddleware.php 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                1.x     #121      +/-   ##
============================================
- Coverage     62.28%   61.37%   -0.92%     
+ Complexity       76       75       -1     
============================================
  Files             4        4              
  Lines           236      277      +41     
============================================
+ Hits            147      170      +23     
- Misses           89      107      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kriskd kriskd force-pushed the fix-schema-deprecation branch from 20e7762 to ad280f5 Compare June 25, 2024 18:55
@kriskd kriskd force-pushed the fix-schema-deprecation branch from ad280f5 to 6f6b4b6 Compare June 25, 2024 19:12
@dereuromark
Copy link
Contributor

dereuromark commented Apr 22, 2025

ping @ADmad
Are those changes good?

//EDIT
I guess this is for Cake4?

@ADmad ADmad merged commit 761b0b8 into ADmad:1.x May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants