Skip to content

Feature: Improve transfer token #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025
Merged

Conversation

jason-aelf
Copy link
Collaborator

No description provided.

Copy link

vizipi bot commented Jun 17, 2025

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% eanzhao 52 6
83.33% louis.li 39 5
83.33% kaiwenzhengaelf 37 5
83.33% chopin.fan 8 5
83.33% zhifenglee-portkey 5 5
66.67% dongqiangaelf 7 4

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
protobuf/token_contract.proto90.00%18 out of 20 times
contract/AElf.Contracts.Profit/ProfitContract.cs85.00%17 out of 20 times
...contract/AElf.Contracts.CrossChain/CrossChainContract_Hel80.00%16 out of 20 times
contract/AElf.Contracts.Economic/EconomicContract.cs80.00%16 out of 20 times
...contract/AElf.Contracts.Election/ElectionContract_Elector80.00%16 out of 20 times
contract/AElf.Contracts.Treasury/TreasuryContract.cs80.00%16 out of 20 times
...test/AElf.Contracts.Economic.TestBase/ContractsPreparatio80.00%16 out of 20 times
...test/AElf.Contracts.MultiToken.Tests/MultiTokenContractTe75.00%15 out of 20 times
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenManagementT75.00%15 out of 20 times
...contract/AElf.Contracts.TokenConverter/TokenConverterCont75.00%15 out of 20 times

Committed file ranks

(click to expand)
  • 97.95%[protobuf/token_contract_impl.proto]
  • 99.11%[...test/AElf.Contracts.MultiToken.Tests/BVT/TokenApplication]
  • 99.59%[contract/AElf.Contracts.MultiToken/TokenContract_Views.cs]
  • 99.45%[contract/AElf.Contracts.MultiToken/TokenContractState.cs]
  • 99.79%[contract/AElf.Contracts.MultiToken/TokenContract_Helper.cs]
  • 99.98%[contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs]
  • Copy link

    codecov bot commented Jun 17, 2025

    Codecov Report

    Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

    Project coverage is 73.54%. Comparing base (3688493) to head (7de9e47).
    Report is 1 commits behind head on dev.

    Files with missing lines Patch % Lines
    ...AElf.Contracts.MultiToken/TokenContract_Actions.cs 84.61% 2 Missing ⚠️
    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev    #3634      +/-   ##
    ==========================================
    + Coverage   73.43%   73.54%   +0.10%     
    ==========================================
      Files         680      680              
      Lines       26229    26250      +21     
      Branches     2358     2360       +2     
    ==========================================
    + Hits        19261    19305      +44     
    + Misses       6815     6792      -23     
      Partials      153      153              
    Files with missing lines Coverage Δ
    ...ct/AElf.Contracts.MultiToken/TokenContract_Fees.cs 36.18% <100.00%> (+0.06%) ⬆️
    .../AElf.Contracts.MultiToken/TokenContract_Helper.cs 63.21% <100.00%> (+1.85%) ⬆️
    ...t/AElf.Contracts.MultiToken/TokenContract_Views.cs 81.22% <100.00%> (+0.26%) ⬆️
    ...AElf.Contracts.MultiToken/TokenContract_Actions.cs 76.22% <84.61%> (+3.87%) ⬆️

    ... and 1 file with indirect coverage changes

    🚀 New features to boost your workflow:
    • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

    @jason-aelf jason-aelf merged commit 2eeeb06 into dev Jun 17, 2025
    10 of 11 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants