feat: added starkent signer and creation of user account on the backend #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSghais
requested changes
Oct 29, 2024
| if (!userAddress) { | ||
| return reply.code(400).send({ message: "User address is required" }); | ||
| } | ||
|
|
There was a problem hiding this comment.
We need to verify the signature in the Backend at this moment.
Please also add a TYPE="STARKNET" for Starknet signature verification.
| updatedAt DateTime @updatedAt | ||
|
|
||
| @@map("users") | ||
| } |
There was a problem hiding this comment.
We maybe need to create a table for Session for user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This pull request enhances the application's functionality by introducing a new feature for verifying the connected account's digital signature. Here's a breakdown of the key changes:
Signature Verification: The system now checks the validity of the user's digital signature. This ensures the authenticity of the connected account.
Existing Account Handling: If the user already has an account, they are logged in seamlessly.
New Account Creation: For users without an existing account, a new account is created, with the user's address stored in the
userAddressfield.Account Model Enhancements: The account model has been expanded to include additional fields, such as
emailandemailVerified. This lays the foundation for potential future enhancements, such as connecting user email addresses.StarkNet Login Flow: The implementation of the StarkNet login flow provides a secure and seamless user experience, including a signer screen for user interactions.
These changes improve the application's security, user experience, and flexibility for future developments.
NB: You account must be deployed before you can have a valid signature.