Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From LibAFL Error for Qemu Error #2641

Merged
merged 6 commits into from
Nov 3, 2024
Merged

Implement From LibAFL Error for Qemu Error #2641

merged 6 commits into from
Nov 3, 2024

Conversation

rmalmain
Copy link
Collaborator

No description provided.

@domenukk
Copy link
Member

So if you're lazy we can merge this, but it might be better to find more useful errors than unknown (in almost every case)

@domenukk
Copy link
Member

Even if we just add a special qemu or instrumentation error type

@rmalmain
Copy link
Collaborator Author

i was thinking of adding an error like instrumentation.
i don't think anything else fits too well

@rmalmain
Copy link
Collaborator Author

rmalmain commented Oct 31, 2024

does it look ok like this?

@domenukk
Copy link
Member

Is it a frontend? :D

@rmalmain
Copy link
Collaborator Author

from libafl's point of view i'd say yes :)
instrumentation sounds ok though, but i thought having a general error for specific things calling into libafl would be convenient at some point.
suggestions welcome

@domenukk
Copy link
Member

From LibAFL's point of view the frontend is the UI, the instrumentation is the backend?
Why not Instrumentation or Runtime or something?

libafl_bolts/src/lib.rs Outdated Show resolved Hide resolved
@domenukk domenukk merged commit 99a156f into main Nov 3, 2024
99 checks passed
@domenukk domenukk deleted the qemu_error branch November 3, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants