Skip to content

Comments

Just even more just#3626

Merged
domenukk merged 53 commits intomainfrom
just_even_more_just
Feb 8, 2026
Merged

Just even more just#3626
domenukk merged 53 commits intomainfrom
just_even_more_just

Conversation

@domenukk
Copy link
Member

Description

describe your PR here

Checklist

  • I have run ./scripts/precommit.sh and addressed all comments

@domenukk domenukk mentioned this pull request Jan 6, 2026
1 task
unsafe {
let signal = &Signal::try_from(sig).unwrap();
#[cfg(feature = "std")]
eprintln!("DEBUG: Handling signal: {:?}", signal);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

#[cfg(unix)]
let child_status = if self.fork {
self.shmem_provider.pre_fork()?;
// Block SIGINT to ensure we can check if it was delivered after waitpid
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to work? :/

// Force linking against libc++
if target_vendor != "apple" && target_family == "unix" {
println!("cargo:rustc-link-lib=dylib=c++");
println!("cargo:rustc-link-lib=dylib=stdc++");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure?

@@ -1,3 +1,4 @@
#![allow(unused_imports)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

} else {
"lqemu".to_string()
};
println!("cargo:warning=API: {api}");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should go

Ok(QemuExitReason::End(QemuShutdownCause::HostSignal(
Signal::SigInterrupt,
))) => process::exit(0),
))) => process::exit(libafl_bolts::os::CTRL_C_EXIT),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That didn't do the trick. Nice try tough

@domenukk
Copy link
Member Author

domenukk commented Feb 8, 2026

Since CI is completely broken right now anyway I'll merge this and then we should fix CI asap

@domenukk domenukk merged commit c59e61e into main Feb 8, 2026
89 of 102 checks passed
@domenukk domenukk deleted the just_even_more_just branch February 8, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant