Skip to content

Internal Change #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Internal Change #1775

wants to merge 1 commit into from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented May 23, 2025 •
edited
Loading

Internal Change

@google-cla Google CLA
Copy link

google-cla bot commented May 23, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@copybara-service copybara-service bot changed the title Update naming to jax ai image Internal Change May 23, 2025
@copybara-service copybara-service bot changed the title Internal Change Update naming to jax ai image May 23, 2025
@copybara-service copybara-service bot force-pushed the test_762520573 branch 2 times, most recently from 8478876 to 14d48b0 Compare May 23, 2025 21:58
@copybara-service copybara-service bot changed the title Update naming to jax ai image Internal Change May 23, 2025
Internal Change
e00626e 
PiperOrigin-RevId: 762520573
bvandermoon
bvandermoon reviewed May 23, 2025
View reviewed changes
Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these files have been moved from MaxText home directory to MaxText/ directory. Not sure why based on the internal CL. But this would cause issues with building the images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvandermoon bvandermoon bvandermoon left review comments

@yangyuwei yangyuwei Awaiting requested review from yangyuwei yangyuwei is a code owner

@parambole parambole Awaiting requested review from parambole parambole is a code owner

@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bvandermoon