add support for cudnn sdpa checkpoint #1805
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cjkkkk
requested review from
gobbleturk,
khatwanimohit,
bvandermoon,
vipannalla,
RissyRan,
richjames0,
gagika,
shralex,
yangyuwei,
SurbhiJainUSC,
hengtaoguo,
A9isha and
aireenmei
as code owners
gobbleturk
approved these changes
Jun 4, 2025
bvandermoon
approved these changes
Jun 4, 2025
bvandermoon
reviewed
Jun 4, 2025
| @@ -911,6 +911,9 @@ def cudnn_jax_flash_attention( | |||
| qkv_layout="BTNH", | |||
| return_residual=True | |||
| ) | |||
| output = checkpoint_name(output, "context") | |||
| lse = checkpoint_name(lse, "context") | |||
| return output, lse | |||
There was a problem hiding this comment.
Does this match the return type hint of Array?
There was a problem hiding this comment.
ya this is good point, its failing our internal lint, probably need to change type hint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for cudnn sdpa checkpoint. This helps avoid recomputation when using remat policy=minimal_flash in maxtext.
Checklist
Before submitting this PR, please make sure (put X in square brackets):