-
Notifications
You must be signed in to change notification settings - Fork 452
Move src/MaxText/distillation to src/maxtext/trainers/post_train/distillation #2956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5445a78 to
432e882
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
432e882 to
1bce907
Compare
|
@codecov-ai-reviewer review |
fc0f8de to
390d532
Compare
|
🤖 Hi @SurbhiJainUSC, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This Pull Request successfully moves the distillation module to a new location (src/maxtext/trainers/post_train/distillation) as part of the repo restructuring. The changes are well-implemented with backward compatibility in mind through a shim, and relevant configuration files have been updated.
🔍 General Feedback
- The approach of using a shim for backward compatibility is a good practice to minimize disruption during code migration.
- The updates to
.coveragerc,codecov.yml, and GitHub Actions workflows (run_pathways_tests.yml,run_tests_against_package.yml) are thorough and correctly reflect the new module structure.
390d532 to
ccbe055
Compare
gagika
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
src/MaxText/distillationtosrc/maxtext/trainers/post_train/distillationas part of repo restructuring work as planned here: https://github.com/AI-Hypercomputer/maxtext/blob/main/RESTRUCTURE.md.src/MaxText/distillationwith a deprecation warning to ensure backward compatibility.Tests
Distillation old command that works:
This old command will work but will also print a warning:
'src.MaxText.distillation.train_distill' is deprecated; use 'src.maxtext.trainers.post_train.distillation.train_distill' instead..Distillation new command that works:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.