Pydantic class TrainContext for train functions (replacing old 11-arity function)
#2964
+114
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelMarks
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
hengtaoguo,
jesselu-google,
jiangjy1982,
khatwanimohit,
lukebaumann,
richjames0,
shauryagup,
shralex,
suexu1025 and
vipannalla
as code owners
SamuelMarks
force-pushed
the
train-pydantic
branch
from
208a2e6 to
b944033
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
SamuelMarks
force-pushed
the
train-pydantic
branch
4 times, most recently
from
c1dae75 to
87ac5f0
Compare
…ontext`, a new pydantic class for defining training context (as opposed to the old 11-arity solution) ; [src/MaxText/{elastic_train,max_utils_test,sft_trainer,train,train_utils}.py,tools/gcs_benchmarks/standalone_dataloader.py] Percolate usage of new `TrainContext`
SamuelMarks
force-pushed
the
train-pydantic
branch
from
87ac5f0 to
ab80eeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A large number of arguments for a function is a code smell. Additionally, usage of Pydantic enables future interesting use-cases like providing all the parameters in, e.g., REST APIs, SQL models, CLIs. And reused across the codebase without duplication. By centralising it to the
class, it also enables future extensibility and refactoring.If the change fixes a bug or a Github issue, please include a link, e.g.,:
N/A
Tests
CI
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.