Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft job portal refactoring #973

Conversation

surapuramakhil
Copy link
Contributor

@surapuramakhil surapuramakhil commented Nov 30, 2024

Refactoring changes

  • job poral
  • jobs pages
  • job page
  • Application page
  • Job Manager, Job Applier - won't be having direct access to the driver, interaction must be done via job portal object.

PS: Linked code here is earlier versions (currently broken)

@surapuramakhil
Copy link
Contributor Author

@sarob as this review might be useful for your feature #831

@feder-cr as you own next creating plugins #975

@surapuramakhil surapuramakhil marked this pull request as ready for review December 1, 2024 13:15
feder-cr
feder-cr previously approved these changes Dec 1, 2024
Copy link
Collaborator

@feder-cr feder-cr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the README needs to be totally rewritten

@surapuramakhil
Copy link
Contributor Author

the README needs to be totally rewritten

I believe this task #976 will handle that.

Copy link
Collaborator

@feder-cr feder-cr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal: Enhance Plugin Management with a Clearer Pattern

Currently, our plugin management lacks a precise and structured approach, which could lead to maintenance challenges and reduced extensibility as the project scales. To address this, I propose adopting Pluggy, a lightweight and flexible framework specifically designed for plugin systems in Python.

Why Pluggy?

Provides a clear mechanism for defining and implementing plugin hooks.
Supports dynamic plugin loading and priority handling.
Simplifies plugin registration and ensures scalability.
Recommended Resources

To get started and better understand the benefits of Pluggy, here are some helpful links:

https://pluggy.readthedocs.io/
https://kracekumar.com/post/build_plugins_with_pluggy/
https://dev.to/waylonwalker/a-minimal-pluggy-example-3mp0
https://waylonwalker.com/python-pluggable-architecture/

@surapuramakhil
Copy link
Contributor Author

surapuramakhil commented Dec 1, 2024

Proposal: Enhance Plugin Management with a Clearer Pattern

Currently, our plugin management lacks a precise and structured approach, which could lead to maintenance challenges and reduced extensibility as the project scales. To address this, I propose adopting Pluggy, a lightweight and flexible framework specifically designed for plugin systems in Python.

Why Pluggy?

Provides a clear mechanism for defining and implementing plugin hooks. Supports dynamic plugin loading and priority handling. Simplifies plugin registration and ensures scalability. Recommended Resources

To get started and better understand the benefits of Pluggy, here are some helpful links:

https://pluggy.readthedocs.io/ https://kracekumar.com/post/build_plugins_with_pluggy/ https://dev.to/waylonwalker/a-minimal-pluggy-example-3mp0 https://waylonwalker.com/python-pluggable-architecture/

this is out of scope, for this PR (this PR only addresses - refactoring, not focuses on plugin, but still extendable for plugin)

@feder-cr
Copy link
Collaborator

feder-cr commented Dec 1, 2024

@surapuramakhil ok

@feder-cr feder-cr self-requested a review December 1, 2024 15:35
@surapuramakhil surapuramakhil merged commit e67ddd4 into AIHawk-FOSS:hotfix/v2024.11.23 Dec 1, 2024
1 check passed
@surapuramakhil surapuramakhil linked an issue Dec 2, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants