Update connection details correctly #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amrc-benmorrow
commented
Apr 28, 2025
amrc-benmorrow
commented
- Internal drivers were being deployed as Driver due to not using the connection store.
- Connection detail updates were not being actioned.
We were generating incorrect configs due to not fetching the _Driver information_ entries. The stores provide a lot of useful functionality; it's foolish not to use them. But currently they do still have a cache coherency issue because we don't have global transactions. The config-generation code already handles this by stopping and restarting the stores; trust the results.
The details are likely to change. The connType may change if a driver is converted from internal to external.
AlexGodbehere
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.