Skip migration of devices without Schema_UUID #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents @acs-service-setup from migrating devices that don't have a schema (where Schema_UUID is null or missing). Previously, the service would attempt to migrate all devices regardless of schema status, which could lead to issues with devices that lack proper schema information. Changes: - Added a check in the register_device method to verify Schema_UUID exists - Added early return with logging when schema is missing or null - Improved code organization by moving schema check earlier in the method This ensures that only properly configured devices with valid schemas are migrated during the setup process.
amrc-benmorrow
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents @acs-service-setup from migrating devices that don't have a schema (where Schema_UUID is null or missing). Previously, the service would attempt to migrate all devices regardless of schema status, which could lead to issues with devices that lack proper schema information.
Changes:
This ensures that only properly configured devices with valid schemas are migrated during the setup process.