Skip to content

Comments

fix the subchandra second pert#2553

Merged
zingale merged 1 commit intoAMReX-Astro:developmentfrom
zingale:fix_subch_pert
Sep 17, 2023
Merged

fix the subchandra second pert#2553
zingale merged 1 commit intoAMReX-Astro:developmentfrom
zingale:fix_subch_pert

Conversation

@zingale
Copy link
Member

@zingale zingale commented Sep 16, 2023

it was overriding the original pert, not adding to it

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

it was overriding the original pert, not adding to it
@zingale zingale changed the title [WIP] fix the subchandra second pert fix the subchandra second pert Sep 16, 2023
@zingale
Copy link
Member Author

zingale commented Sep 16, 2023

okay, this works correctly now

@zingale zingale merged commit 54271a9 into AMReX-Astro:development Sep 17, 2023
@zingale zingale deleted the fix_subch_pert branch September 17, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants