implement full well-balancing in PPM #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the best results now come from use_pslope and reflecting BCs this is because of work we've done since the README was last updated.
|
this seems to work |
|
This seems to work. Here's a version of
and here it is with normal PPM and reflecting BCs:
|
zingale
changed the title
zhichen3
reviewed
Oct 23, 2024
| @@ -459,6 +477,10 @@ Castro::trace_ppm(const Box& bx, | |||
| } | |||
|
|
|||
|
|
|||
| // for well-balanced, the velocity sources should not be added | |||
|
|
|||
| amrex::Real fac = (castro::ppm_well_balanced && in_hse) ? 0.0_rt : 1.0_rt; | |||
There was a problem hiding this comment.
is it better to just skip the source trace tracing for src_un above if we use ppm_well_balaneced and in_hse?
There was a problem hiding this comment.
I guess so, but somehow I thought this was more clear when reading the code.
zhichen3
reviewed
Oct 24, 2024
Source/hydro/trace_ppm.cpp
Outdated
| Real trho[nslp]; | ||
| Real src[nslp]; | ||
|
|
||
| load_stencil(q_arr, idir, i, j, k, QRHO, trho); | ||
| load_stencil(srcQ, idir, i, j, k, QUN, src); | ||
|
|
||
| ppm_reconstruct_pslope(trho, s, src, flat, dL, sm, sp); | ||
| in_hse = ppm_reconstruct_pslope(trho, s, src, flat, dx[idir], sm, sp); |
There was a problem hiding this comment.
probably better to pass in dL rather than dx[idir] although it only makes a difference in spherical-theta direction but gravity is in r so there will be no difference, but I still feel its more consistent this way. Same goes with using dL to get p_m_hse and p_p_hse later.
zhichen3
approved these changes
Oct 24, 2024
zhichen3
added a commit
to zhichen3/Castro
that referenced
this pull request
Oct 30, 2024
This reverts commit db92cba.
zhichen3
added a commit
to zhichen3/Castro
that referenced
this pull request
Oct 30, 2024
This reverts commit b280340.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate