Performance optimizations for QSS chemistry #561
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR with optimizations from the NREL/NOAA/NCAR Open Hackathon:
k_f- just compute it on an as-needed basis (1% performance gain)qfandqrcomputed during QSS coefficient calculation instead of recomputing (10% cumulative performance gain)Nsight Compute profiles of the reaction kernel, before, after (1), and after (2), respectively:



Another optimization that was tried by @SreejithNREL was adding
#pragma unrollto various species loops - that didn't have an effect as the compiler seems to being doing it automatically without the pragma.TODOs:
Thanks @dappelha and @uumesh for the suggestions leading to this PR! Hopefully I got your github handles right.