Skip to content

Fix LAPPD time alignment plots #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: online_monitoring
Choose a base branch
from

Conversation

furkan-bilgin
Copy link

Describe your changes

This PR rollsback the previously added 2D LAPPD last 100 file time alignment histograms that was removed by pull request #319 due to it being worked on the Application branch of ToolAnalysis, not online_monitoring, as the said 2D plots were introduced in the commit 727ba58 was not present in the main branch.

It also changes the last 1000 file time alignment histogram to 2D as well.

Checklist before submitting your PR

  • [ X ] This PR implements a single change (one new/modified Tool, or a set of changes to implement one new/modified feature)
  • [ X ] This PR alters the minimum number of files to affect this change
  • [ X ] If this PR includes a new Tool, a README and minimal demonstration ToolChain is provided
  • [ X ] If a new Tool/ToolChain requires model or configuration files, their paths are not hard-coded, and means of generating those files is described in the readme, with examples provided on /pnfs/annie/persistent
  • [ X ] For every new usage, there is a reason the data must be on the heap
  • [ X ] For every new there is a delete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant