chore: remove WhisperMesh protocol and NATS dependencies #67
Conversation
WhisperMesh protocol idea was abandoned in favor of simpler alternatives. Removed: - src/Libraries/WhisperMesh/ (entire library) - tests/Ancplua.Mcp.WhisperMesh.Tests/ (test project) - docs/decisions/ADR-0107-whispermesh-protocol-adoption.md - docs/specs/spec-0110-whispermesh-phase1-implementation.md - docs/specs/spec-whispermesh-protocol.md - NATS.Client.Core and NATS.Client.JetStream package references - NATS service from docker-compose.yml - WhisperAggregatorTools from tool-contracts.md Co-authored-by: Alexander Nachtmann <[email protected]> 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Caution Review failedThe pull request is closed. WalkthroughThe pull request removes the entire WhisperMesh ecosystem from the project, including the WhisperMesh library, NATS JetStream integration, related tests, documentation, and configuration references. This is a comprehensive cleanup that eliminates WhisperMesh-specific code, dependencies, ADRs, specifications, and settings across the codebase and solution structure. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (30)
Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Summary of ChangesHello @ANcpLua, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completely removes the WhisperMesh protocol and its underlying NATS messaging infrastructure. The decision to abandon WhisperMesh was driven by the adoption of simpler alternative solutions for inter-agent communication. This change streamlines the project by eliminating unused code, dependencies, and configuration, reducing complexity and maintenance overhead. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleanly removes the abandoned WhisperMesh protocol and its NATS dependencies. The changes are comprehensive, covering source code, tests, documentation, package management, and container configurations. All related files and references appear to have been correctly removed. My only suggestion is to refactor the CHANGELOG.md to consolidate entries under standard headings for better readability and maintainability.
| ### Removed | ||
| - **WhisperMesh Protocol Removed (2025-12-02):** | ||
| - Removed entire `src/Libraries/WhisperMesh/` library (NATS-based agent-to-agent communication) | ||
| - Removed `tests/Ancplua.Mcp.WhisperMesh.Tests/` test project | ||
| - Removed WhisperMesh documentation: | ||
| - `docs/decisions/ADR-0107-whispermesh-protocol-adoption.md` | ||
| - `docs/specs/spec-0110-whispermesh-phase1-implementation.md` | ||
| - `docs/specs/spec-whispermesh-protocol.md` | ||
| - Removed NATS.Client.Core and NATS.Client.JetStream package references from Directory.Packages.props | ||
| - Cleaned up WhisperMesh configuration from Workstation server appsettings.json | ||
| - **Reason**: Protocol idea was abandoned in favor of simpler alternatives |
There was a problem hiding this comment.
The [Unreleased] section has become difficult to read due to repeated headings (e.g., multiple ### Changed, ### Security sections). This deviates from the 'Keep a Changelog' format which recommends grouping all changes of a certain type under a single heading for each release.
To improve maintainability and readability, I recommend consolidating all entries under their respective standard headings (Added, Changed, Deprecated, Removed, Fixed, Security).
For example, all items currently under various ### Changed headings should be merged into one. The same applies to ### Security, ### Added, etc.
Custom headings like ### New Features should be mapped to standard ones, in this case ### Added. Similarly, ### Architecture & Infrastructure and ### Code Ergonomics (C# 14) could be grouped under ### Changed.
This will make the changelog much clearer for developers and users tracking upcoming changes.
There was a problem hiding this comment.
Pull request overview
This PR removes the WhisperMesh protocol implementation and all NATS dependencies from the ancplua-mcp repository. The WhisperMesh protocol was an ambient agent-to-agent communication system that was abandoned in favor of simpler alternatives. The removal is comprehensive and includes the library code, tests, documentation (ADRs and specs), NATS client package dependencies, docker-compose NATS service, and related configuration.
Key Changes
- Removed entire
src/Libraries/WhisperMesh/library andtests/Ancplua.Mcp.WhisperMesh.Tests/test project - Removed WhisperMesh protocol documentation (ADR-0107, spec-0110, spec-whispermesh-protocol.md)
- Cleaned up NATS package references, docker-compose NATS service, and configuration files
- Updated CHANGELOG.md and ARCHITECTURE.md to reflect the removal
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Documents the WhisperMesh removal with comprehensive details |
| Directory.Packages.props | Removes NATS.Client.Core and NATS.Client.JetStream package references |
| docker-compose.yml | Removes NATS JetStream service and volume configuration |
| ancplua-mcp.sln | Removes WhisperMesh library and test projects from solution |
| docs/ARCHITECTURE.md | Updates architecture diagram removing WhisperMesh references |
| src/Servers/Stdio/Workstation/appsettings.json | Removes WhisperMesh configuration section |
| src/Servers/Stdio/Workstation/Program.cs | Removes WhisperMesh comment |
| Dockerfile.workstation | Removes WhisperMesh-related comment |
| docs/tool-contracts.md | Removes WhisperAggregatorTools documentation |
| docs/specs/*.md | Removes WhisperMesh specification documents |
| docs/decisions/ADR-0107-*.md | Removes WhisperMesh ADR |
| src/Libraries/WhisperMesh/* | Removes entire WhisperMesh library implementation |
| tests/Ancplua.Mcp.WhisperMesh.Tests/* | Removes all WhisperMesh tests |
WhisperMesh protocol idea was abandoned in favor of simpler alternatives.
Related to: #66
Generated with Claude Code
Summary by CodeRabbit
Revert
Chores
✏️ Tip: You can customize this high-level summary in your review settings.