Fix: Updated SQL schema to resolve missing tables errors #181
Conversation
WalkthroughReplaces prior minimal integration scaffold with a full database re-initialization: creates Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (4)
backend/database/01_create_integration_tables.sql (4)
47-47: Recommended: Add CHECK constraints for enum-like status fields.Lines 47, 49, 100, and 101 reference status-like fields (
platform,is_active,indexing_status,is_deleted) but lack validation beyond theplatformCHECK constraint (line 47). Strengthen data integrity with explicit CHECK constraints on other status fields.indexed_status TEXT DEFAULT 'pending', + indexing_status TEXT DEFAULT 'pending' CHECK (indexing_status IN ('pending', 'in_progress', 'completed', 'failed')),Add similar CHECK constraints for
is_active,is_deleted, and other constrained fields to prevent invalid states.Also applies to: 49-49, 100-100, 101-101
13-114: Recommended: Addcreated_attoconversation_contexttable.The
conversation_contexttable (lines 63–67) lacks acreated_atcolumn, which is present in all other tables. This makes auditing and lifecycle tracking inconsistent across the schema.CREATE TABLE public.conversation_context ( user_id UUID REFERENCES public.users(id) ON DELETE CASCADE PRIMARY KEY, context JSONB DEFAULT '{}', + created_at TIMESTAMPTZ DEFAULT NOW(), updated_at TIMESTAMPTZ DEFAULT NOW() );
34-36: Recommended: Consider automaticupdated_attrigger mechanism.Several tables define
updated_atcolumns with DEFAULT NOW(), but this only sets the timestamp at insert time. To keepupdated_atcurrent on every UPDATE, add a trigger or use a PostgreSQL extension likemoddatetime.Document or implement an automatic update mechanism (e.g., a before-update trigger) to keep
updated_atsynchronized with actual row modifications.Also applies to: 51-52, 76-76, 102-103
14-14: Optional: Consider addingNOT NULLtoidcolumn for clarity.While
DEFAULT gen_random_uuid()ensuresidis always populated, explicitly marking itNOT NULLdocuments the guarantee and prevents future changes.- id UUID PRIMARY KEY DEFAULT gen_random_uuid(), + id UUID PRIMARY KEY NOT NULL DEFAULT gen_random_uuid(),This is a minor documentation improvement; no functional change is required.
| -- ========================================================= | ||
| -- STEP 1: FULL CLEANUP | ||
| -- ========================================================= | ||
| DROP TABLE IF EXISTS public.indexed_repositories CASCADE; | ||
| DROP TABLE IF EXISTS public.interactions CASCADE; | ||
| DROP TABLE IF EXISTS public.conversation_context CASCADE; | ||
| DROP TABLE IF EXISTS public.organization_integrations CASCADE; | ||
| DROP TABLE IF EXISTS public.users CASCADE; | ||
|
|
||
| -- ========================================================= | ||
| -- STEP 2: CREATE USERS TABLE | ||
| -- ========================================================= | ||
| CREATE TABLE public.users ( | ||
| id UUID PRIMARY KEY DEFAULT gen_random_uuid(), | ||
| user_id UUID NOT NULL REFERENCES auth.users(id) ON DELETE CASCADE, | ||
| discord_id TEXT UNIQUE, | ||
| email TEXT, | ||
| full_name TEXT, | ||
| avatar_url TEXT, | ||
| discord_username TEXT, | ||
| display_name TEXT, | ||
| preferred_languages TEXT[], | ||
| last_active_discord TIMESTAMPTZ DEFAULT NOW(), | ||
|
|
||
| -- Verification Columns | ||
| verification_token TEXT, | ||
| verification_token_expires_at TIMESTAMPTZ, | ||
|
|
||
| -- GitHub Data Columns | ||
| github_id TEXT, | ||
| github_username TEXT, | ||
| is_verified BOOLEAN DEFAULT FALSE, | ||
| verified_at TIMESTAMPTZ, | ||
|
|
||
| created_at TIMESTAMPTZ DEFAULT NOW(), | ||
| updated_at TIMESTAMPTZ DEFAULT NOW() | ||
| ); | ||
|
|
||
| ALTER TABLE public.users ENABLE ROW LEVEL SECURITY; | ||
| CREATE POLICY "Public Access Users" ON public.users FOR ALL USING (true) WITH CHECK (true); | ||
|
|
||
| -- ========================================================= | ||
| -- STEP 3: INTEGRATIONS TABLE | ||
| -- ========================================================= | ||
| CREATE TABLE public.organization_integrations ( | ||
| id UUID PRIMARY KEY DEFAULT gen_random_uuid(), | ||
| user_id UUID REFERENCES public.users(id) ON DELETE CASCADE, | ||
| platform VARCHAR(50) NOT NULL CHECK (platform IN ('github', 'discord', 'slack', 'discourse')), | ||
| organization_name VARCHAR(255) NOT NULL, | ||
| is_active BOOLEAN NOT NULL DEFAULT true, | ||
| config JSONB DEFAULT '{}', -- Stores org link, discord_guild_id, etc. | ||
| config JSONB DEFAULT '{}', | ||
| created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(), | ||
| updated_at TIMESTAMPTZ NOT NULL DEFAULT NOW(), | ||
|
|
||
| -- Ensure one integration per user per platform | ||
| UNIQUE(user_id, platform) | ||
| ); | ||
|
|
||
| -- Create indexes for better query performance | ||
| CREATE INDEX IF NOT EXISTS idx_org_integrations_user_id ON organization_integrations(user_id); | ||
| CREATE INDEX IF NOT EXISTS idx_org_integrations_platform ON organization_integrations(platform); | ||
| CREATE INDEX IF NOT EXISTS idx_org_integrations_is_active ON organization_integrations(is_active); | ||
| ALTER TABLE public.organization_integrations ENABLE ROW LEVEL SECURITY; | ||
| CREATE POLICY "Public Access Orgs" ON organization_integrations FOR ALL USING (true) WITH CHECK (true); | ||
|
|
||
| -- Create function to automatically update updated_at timestamp | ||
| CREATE OR REPLACE FUNCTION update_updated_at_column() | ||
| RETURNS TRIGGER AS $$ | ||
| BEGIN | ||
| NEW.updated_at = NOW(); | ||
| RETURN NEW; | ||
| END; | ||
| $$ LANGUAGE plpgsql; | ||
|
|
||
| -- Create triggers to automatically update updated_at | ||
| CREATE TRIGGER update_organization_integrations_updated_at | ||
| BEFORE UPDATE ON organization_integrations | ||
| FOR EACH ROW | ||
| EXECUTE FUNCTION update_updated_at_column(); | ||
| -- ========================================================= | ||
| -- STEP 4: MEMORY TABLES | ||
| -- ========================================================= | ||
| CREATE TABLE public.conversation_context ( | ||
| user_id UUID REFERENCES public.users(id) ON DELETE CASCADE PRIMARY KEY, | ||
| context JSONB DEFAULT '{}', | ||
| updated_at TIMESTAMPTZ DEFAULT NOW() | ||
| ); | ||
|
|
||
| -- Enable Row Level Security (RLS) | ||
| ALTER TABLE organization_integrations ENABLE ROW LEVEL SECURITY; | ||
| CREATE TABLE public.interactions ( | ||
| id UUID PRIMARY KEY DEFAULT gen_random_uuid(), | ||
| user_id UUID REFERENCES public.users(id) ON DELETE CASCADE, | ||
| session_id TEXT, | ||
| input_text TEXT, | ||
| output_text TEXT, | ||
| tool_usage JSONB DEFAULT '[]', | ||
| created_at TIMESTAMPTZ DEFAULT NOW() | ||
| ); | ||
|
|
||
| -- Create RLS policies for organization_integrations | ||
| -- Users can only see and manage their own integrations | ||
| CREATE POLICY "Users can view their own integrations" | ||
| ON organization_integrations | ||
| FOR SELECT | ||
| USING (auth.uid() = user_id); | ||
| ALTER TABLE public.conversation_context ENABLE ROW LEVEL SECURITY; | ||
| CREATE POLICY "Public Context Access" ON conversation_context FOR ALL USING (true) WITH CHECK (true); | ||
|
|
||
| CREATE POLICY "Users can create their own integrations" | ||
| ON organization_integrations | ||
| FOR INSERT | ||
| WITH CHECK (auth.uid() = user_id); | ||
| ALTER TABLE public.interactions ENABLE ROW LEVEL SECURITY; | ||
| CREATE POLICY "Public Interaction Access" ON interactions FOR ALL USING (true) WITH CHECK (true); | ||
|
|
||
| CREATE POLICY "Users can update their own integrations" | ||
| ON organization_integrations | ||
| FOR UPDATE | ||
| USING (auth.uid() = user_id) | ||
| WITH CHECK (auth.uid() = user_id); | ||
| -- ========================================================= | ||
| -- STEP 5: INDEXED REPOSITORIES (With Fixed Column) | ||
| -- ========================================================= | ||
| CREATE TABLE public.indexed_repositories ( | ||
| id UUID PRIMARY KEY DEFAULT gen_random_uuid(), | ||
| user_id UUID REFERENCES public.users(id) ON DELETE CASCADE, | ||
| repository_full_name TEXT NOT NULL, | ||
| graph_name TEXT NOT NULL, | ||
|
|
||
|
|
||
| CREATE POLICY "Users can delete their own integrations" | ||
| ON organization_integrations | ||
| FOR DELETE | ||
| USING (auth.uid() = user_id); | ||
| indexed_by_discord_id TEXT, | ||
|
|
||
| branch TEXT DEFAULT 'main', | ||
| node_count INTEGER DEFAULT 0, | ||
| edge_count INTEGER DEFAULT 0, | ||
| indexing_status TEXT DEFAULT 'pending', | ||
| is_deleted BOOLEAN DEFAULT FALSE, | ||
| created_at TIMESTAMPTZ DEFAULT NOW(), | ||
| updated_at TIMESTAMPTZ DEFAULT NOW(), | ||
| UNIQUE(user_id, repository_full_name) | ||
| ); | ||
|
|
||
| -- Add helpful comments | ||
| COMMENT ON TABLE organization_integrations IS 'Stores registered organizations (just metadata, no tokens)'; | ||
| COMMENT ON COLUMN organization_integrations.config IS 'Platform-specific data: organization_link, discord_guild_id, etc.'; | ||
| CREATE INDEX IF NOT EXISTS idx_indexed_repos_user ON indexed_repositories(user_id); | ||
| ALTER TABLE public.indexed_repositories ENABLE ROW LEVEL SECURITY; | ||
| CREATE POLICY "Public Index Access" ON indexed_repositories FOR ALL USING (true) WITH CHECK (true); | ||
|
|
||
| -- ========================================================= | ||
| -- STEP 6: FINAL REFRESH | ||
| -- ========================================================= | ||
| NOTIFY pgrst, 'reload schema'; |
There was a problem hiding this comment.
Major: Schema migration drops all tables without data preservation.
Lines 4–8 use DROP TABLE ... CASCADE on all tables. If this migration is applied to an environment with existing data, all data is lost. There is no rollback or data preservation strategy documented.
Clarify the migration intent:
- Is this migration intended for a fresh environment only (dev/test)? If so, document this assumption.
- Is this a production migration with existing data? If so, use
CREATE TABLE IF NOT EXISTSand add separateALTER TABLEstatements to evolve the schema without data loss.
Example for production-safe approach:
- DROP TABLE IF EXISTS public.indexed_repositories CASCADE;
- ...
+ -- Only drop if truly necessary; otherwise use IF NOT EXISTS and ALTERs
+ CREATE TABLE IF NOT EXISTS public.users (Document migration assumptions and rollback procedures.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
backend/database/01_create_integration_tables.sql lines 4-8: the migration
unconditionally drops all tables with DROP TABLE ... CASCADE which will
irreversibly delete production data; replace this destructive behavior by either
(A) explicitly marking this file as "fresh environment only" in the header and
removing or guarding the DROP statements, or (B) making the script
production-safe by removing the global DROPs and using CREATE TABLE IF NOT
EXISTS plus targeted ALTER TABLE statements to evolve existing tables, add
explicit backup/backup-check and rollback steps (dump or transactional
migration) and include documentation/comments that state the intended
environment and rollback procedure.
| CREATE TABLE public.users ( | ||
| id UUID PRIMARY KEY DEFAULT gen_random_uuid(), | ||
| user_id UUID NOT NULL REFERENCES auth.users(id) ON DELETE CASCADE, | ||
| discord_id TEXT UNIQUE, | ||
| email TEXT, | ||
| full_name TEXT, | ||
| avatar_url TEXT, | ||
| discord_username TEXT, | ||
| display_name TEXT, | ||
| preferred_languages TEXT[], | ||
| last_active_discord TIMESTAMPTZ DEFAULT NOW(), | ||
|
|
||
| -- Verification Columns | ||
| verification_token TEXT, | ||
| verification_token_expires_at TIMESTAMPTZ, | ||
|
|
||
| -- GitHub Data Columns | ||
| github_id TEXT, | ||
| github_username TEXT, | ||
| is_verified BOOLEAN DEFAULT FALSE, | ||
| verified_at TIMESTAMPTZ, | ||
|
|
||
| created_at TIMESTAMPTZ DEFAULT NOW(), | ||
| updated_at TIMESTAMPTZ DEFAULT NOW() | ||
| ); |
There was a problem hiding this comment.
Major: Missing indexes on UNIQUE identifier columns.
Lines 15 and 29 define discord_id and github_id as UNIQUE but don't create explicit indexes. While Postgres auto-indexes UNIQUE constraints, explicit indexes improve query performance for lookups. Additionally, discord_id is nullable but appears to be a user identifier—this is inconsistent.
Add explicit indexes and clarify the design:
+ CREATE UNIQUE INDEX IF NOT EXISTS idx_users_discord_id ON public.users(discord_id) WHERE discord_id IS NOT NULL;
+ CREATE UNIQUE INDEX IF NOT EXISTS idx_users_github_id ON public.users(github_id) WHERE github_id IS NOT NULL;Consider whether discord_id should be NOT NULL if it's the primary user identifier. If users can register without Discord, document the onboarding flow.
🤖 Prompt for AI Agents
In backend/database/01_create_integration_tables.sql around lines 13 to 36, the
table defines UNIQUE identifiers (discord_id and github_id) but lacks explicit
indexes and discord_id is nullable which is inconsistent for a primary
identifier; add CREATE INDEX IF NOT EXISTS statements for discord_id and
github_id (and any other frequently queried identifier like email) to ensure
performant lookups, and decide whether discord_id should be NOT NULL (if Discord
is required) or keep it nullable and document the onboarding flow that allows
non-Discord users—update the table DDL accordingly or add developer notes
explaining the design choice.
| ); | ||
|
|
||
| ALTER TABLE public.users ENABLE ROW LEVEL SECURITY; | ||
| CREATE POLICY "Public Access Users" ON public.users FOR ALL USING (true) WITH CHECK (true); |
There was a problem hiding this comment.
Critical: RLS policies expose all user data to all users.
All row-level security policies use permissive USING (true) WITH CHECK (true) access. This allows any authenticated user to read and modify any other user's data, including conversations, repository indexes, and credentials. This is a fundamental authorization flaw.
These policies should scope access to the authenticated user, not grant blanket public access. For example, replace line 39 with policies that check the user's identity.
- CREATE POLICY "Public Access Users" ON public.users FOR ALL USING (true) WITH CHECK (true);
+ CREATE POLICY "User Self Access" ON public.users
+ FOR SELECT USING (auth.uid()::uuid = id)
+ FOR UPDATE USING (auth.uid()::uuid = id)
+ FOR DELETE USING (auth.uid()::uuid = id)
+ FOR INSERT WITH CHECK (auth.uid()::uuid = id);Apply similar scoped access patterns to all other tables (organization_integrations, conversation_context, interactions, indexed_repositories). Verify this matches your application's intended access control model.
Also applies to: 58-58, 80-80, 83-83, 109-109
🤖 Prompt for AI Agents
In backend/database/01_create_integration_tables.sql around line 39 (and
similarly lines 58, 80, 83, 109), the RLS policies are overly permissive (USING
(true) WITH CHECK (true)); replace them with scoped policies that restrict rows
to the authenticated user or a valid membership check. For per-user tables
(e.g., users, conversation_context, interactions, indexed_repositories) change
the USING/WITH CHECK expressions to compare the row owner column (id, user_id,
owner_id, etc.) to auth.uid() so only the owning user can
SELECT/INSERT/UPDATE/DELETE their rows; for organization-scoped tables (e.g.,
organization_integrations) use a membership check (e.g., EXISTS against an
organization_members table or a function that verifies the current auth.uid() is
a member of the organization) in the USING/WITH CHECK clauses. Apply these
scoped replacements to the listed lines and audit other table policies to ensure
no policy remains USING (true) WITH CHECK (true).
| -- ========================================================= | ||
| CREATE TABLE public.organization_integrations ( | ||
| id UUID PRIMARY KEY DEFAULT gen_random_uuid(), | ||
| user_id UUID REFERENCES public.users(id) ON DELETE CASCADE, |
There was a problem hiding this comment.
Major: Foreign key columns lack NOT NULL constraints.
Lines 46, 71, and 90 define user_id without NOT NULL, allowing orphaned rows when a user_id is missing. These columns should be mandatory.
- user_id UUID REFERENCES public.users(id) ON DELETE CASCADE,
+ user_id UUID NOT NULL REFERENCES public.users(id) ON DELETE CASCADE,Apply this fix to organization_integrations (line 46), interactions (line 71), and indexed_repositories (line 90).
Also applies to: 71-71, 90-90
| -- STEP 4: MEMORY TABLES | ||
| -- ========================================================= | ||
| CREATE TABLE public.conversation_context ( | ||
| user_id UUID REFERENCES public.users(id) ON DELETE CASCADE PRIMARY KEY, |
There was a problem hiding this comment.
Major: conversation_context design limits one context per user.
Line 64 defines user_id as the PRIMARY KEY, which enforces a 1:1 relationship—each user can have only one conversation context. If the intent is to support multiple conversations per user, this design is insufficient.
If supporting multiple conversations is required:
- CREATE TABLE public.conversation_context (
- user_id UUID REFERENCES public.users(id) ON DELETE CASCADE PRIMARY KEY,
+ CREATE TABLE public.conversation_context (
+ id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
+ user_id UUID NOT NULL REFERENCES public.users(id) ON DELETE CASCADE,
context JSONB DEFAULT '{}',
updated_at TIMESTAMPTZ DEFAULT NOW()
+ );
+ CREATE INDEX IF NOT EXISTS idx_conversation_context_user_id ON conversation_context(user_id);If limiting to one context per user is intentional, document this constraint clearly.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
backend/database/01_create_integration_tables.sql around line 64: user_id is
declared as PRIMARY KEY which enforces a 1:1 relationship and prevents multiple
conversation contexts per user; to allow multiple contexts, remove the PRIMARY
KEY from user_id and instead add a dedicated primary key (e.g., id UUID PRIMARY
KEY) or introduce a conversation_id and use a composite key (user_id,
conversation_id) and index user_id as a foreign key; if the 1:1 constraint is
intentional, add a clear comment or documentation note above the column
explaining that only one conversation_context is allowed per user.
There was a problem hiding this comment.
@coderabbitai Thanks for the review. Since this script is intended for local development setup to fix the PGRST204 schema errors, I have kept the RLS policies permissive (USING true) to avoid permission issues during initial onboarding. The DROP TABLE statements are also intentional to ensure a clean state during setup.
There was a problem hiding this comment.
@HamzaNasiem Thanks for the context! I understand the RLS policies are permissive for local development, and the DROP TABLE statements ensure a clean setup—that makes sense for the use case.
My original comment was specifically about the conversation_context table design (Line 64), where user_id is declared as the PRIMARY KEY. This enforces a 1:1 relationship, meaning each user can have only one conversation context record.
My question is: Is this intentional?
- If you want to support multiple conversation contexts per user (e.g., multiple chat sessions), the current design won't allow it.
- If you only need one context per user (e.g., storing a single global conversation state), then the current design is correct.
Could you clarify which behavior you're aiming for? That way, we can ensure the schema aligns with your requirements. 😊
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
backend/database/01_create_integration_tables.sql (3)
90-90: Add NOT NULL constraint touser_idforeign key inindexed_repositoriestable.Line 90 defines
user_idwithoutNOT NULL, allowing orphaned rows. An indexed repository must belong to a user. Add NOT NULL:- user_id UUID REFERENCES public.users(id) ON DELETE CASCADE, + user_id UUID NOT NULL REFERENCES public.users(id) ON DELETE CASCADE,
46-46: Add NOT NULL constraint touser_idforeign key.Line 46 defines
user_idwithoutNOT NULL, allowing orphaned rows if user_id is absent. An organization integration must belong to a user. Add NOT NULL:- user_id UUID REFERENCES public.users(id) ON DELETE CASCADE, + user_id UUID NOT NULL REFERENCES public.users(id) ON DELETE CASCADE,
71-71: Add NOT NULL constraint touser_idforeign key ininteractionstable.Line 71 defines
user_idwithoutNOT NULL, allowing orphaned rows. An interaction must belong to a user. Add NOT NULL:- user_id UUID REFERENCES public.users(id) ON DELETE CASCADE, + user_id UUID NOT NULL REFERENCES public.users(id) ON DELETE CASCADE,
🧹 Nitpick comments (2)
backend/database/01_create_integration_tables.sql (2)
1-8: Clear and safe cleanup for dev environment.Thanks for clarifying that this is a local development setup script. The use of
DROP TABLE IF EXISTS ... CASCADEis safe and appropriate here since this is explicitly intended for fresh re-initialization. To prevent accidental misuse in other contexts, consider adding a prominent comment at the very top of the file (before line 1) explicitly stating:-- ⚠️ WARNING: This is a development-only schema initialization script. -- It performs a complete table reset and is only safe for fresh/test environments. -- Do NOT use this in production without understanding the destructive nature.
15-15: Clarify nullable identifier columns and add explicit indexes on UNIQUE constraints.Lines 15 and 29 define
discord_idandgithub_idas UNIQUE but nullable. Two concerns:
Identifier clarity: If
discord_idis the primary user identifier, it should beNOT NULL. If users can register without Discord (e.g., via email or GitHub only), document this onboarding assumption.Index performance: While PostgreSQL auto-indexes UNIQUE constraints, explicit indexes are clearer and improve lookup performance. Add:
CREATE UNIQUE INDEX IF NOT EXISTS idx_users_discord_id ON public.users(discord_id) WHERE discord_id IS NOT NULL; CREATE UNIQUE INDEX IF NOT EXISTS idx_users_github_id ON public.users(github_id) WHERE github_id IS NOT NULL;Also applies to: 29-29
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
backend/database/01_create_integration_tables.sql(1 hunks)
🔇 Additional comments (2)
backend/database/01_create_integration_tables.sql (2)
64-64: Clarify intent forconversation_context1:1 design.Line 64 declares
user_idas PRIMARY KEY, enforcing a 1:1 relationship—each user can have only one conversation context. This was flagged in the previous review, and I'd like to confirm:Is this intentional?
- If you want to support multiple conversation contexts per user (e.g., multiple chat sessions), the current schema must be redesigned (add a dedicated
idPK and indexuser_id).- If you want exactly one context per user, the current design is correct but should be documented with a clear comment.
Please clarify so we can align the schema with your requirements.
113-116: LGTM!The
NOTIFY pgrst, 'reload schema'is the correct PostgREST signal to refresh the schema after initialization.
1 participant
Closes #
📝 Description
🔧 Changes Made
📷 Screenshots or Visual Changes (if applicable)
🤝 Collaboration
Collaborated with:
@username(optional)✅ Checklist
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.