Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Open project links in new tab and resolved invalid <Link> with <a> child error. #244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AadilAliShaikh
Copy link

@AadilAliShaikh AadilAliShaikh commented Aug 20, 2024

What does this PR do?

  • This PR updates the project links in the Projects section to open in a new tab by adding target="_blank" to the anchor tags.
  • It also resolves the <a> in <Link> error by removing the nested <a> tag and using the passHref prop correctly in the next/link component.

Why are these changes necessary?

  • The project links currently open in the same tab, which disrupts the user experience by taking users away from the AOSSIE website.
  • The <a> in <Link> error was causing a server-side rendering issue, which needed to be fixed for the website to function correctly.

How does it address the issue?

  • The target="_blank" attribute was added to the anchor tags within the project cards, ensuring links open in a new tab.
  • The nested <a> tag was removed from within the Link component to follow Next.js best practices, preventing the error.

Additional Context

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 7:34pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant