Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: inherit encoding type from Plugin for text parsing option #341

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

liamc-altruistiq
Copy link
Contributor

When compiled, there is a type error that makes builds fail on a package that I would like to use this as a dependency. It's related to Plugin.parse.text which appears to have some overriding typing for the encoding option. This just removes that override and instead inherits the BufferEncoding type from Plugin.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8537520040

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 92.143%

Totals Coverage Status
Change from base Build 8180472623: -0.07%
Covered Lines: 3363
Relevant Lines: 3622

💛 - Coveralls

@jonluca jonluca merged commit d76f98d into APIDevTools:main Apr 7, 2024
13 of 14 checks passed
@liamc-altruistiq liamc-altruistiq deleted the chore/buffer-types branch April 15, 2024 08:25
@liamc-altruistiq
Copy link
Contributor Author

@jonluca will a force-release be necessary here? the CI action claims that nothing of note has changed (which I guess is true) but the built dist files in the package will still contain the invalid types that are of concern.

@jonluca
Copy link
Collaborator

jonluca commented Apr 15, 2024

Yeah need to make a commit with a fix: , I'll take a look

Copy link

🎉 This PR is included in version 11.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants