Support batch deletion #70

tuancoltech · 2024-08-04T08:14:38Z

Description:

Support batch deletion: #47

Screenshots:

shubertm

SVID_20241022_213104_1.mp4

Long click must select the item
Back button should deselect all
Switch off screen after selection and all checked states are lost

SVID_20241023_153320_1.mp4

Ripple should have shape of the note item. Observe carefully

tuancoltech · 2024-11-10T09:07:05Z

Good work @tuancoltech

SVID_20241029_103736_1.mp4

While in selection mode, clicking a note should add it to selection not open it. Opening should happen out of selection mode.

@shubertm This has been fixed. Please help check again!

shubertm · 2024-11-12T02:51:08Z

app/src/main/java/dev/arkbuilders/arkmemo/repo/NotesRepoHelper.kt

@@ -91,6 +91,13 @@ class NotesRepoHelper
            return UserNoteProperties(title, description)
        }

+        suspend fun deleteNote(notes: List<Note>): Unit =


Suggested change

suspend fun deleteNote(notes: List<Note>): Unit =

suspend fun deleteNotes(notes: List<Note>): Unit =

shubertm · 2024-11-12T02:54:34Z

app/src/main/java/dev/arkbuilders/arkmemo/ui/adapters/NotesListAdapter.kt

+
+    private val selectedNoteCount by lazy { MutableLiveData<Int>() }
+    val observableSelectedNoteCount by lazy { selectedNoteCount }
+    val selectedNotedForDelete = mutableListOf<Note>()


Suggested change

val selectedNotedForDelete = mutableListOf<Note>()

val selectedNotesForDelete = mutableListOf<Note>()

@shubertm Thanks. Please review again!

shubertm

Please fix problem with exposing mutable variables wherever possible

shubertm · 2024-11-14T05:02:19Z

app/src/main/java/dev/arkbuilders/arkmemo/ui/adapters/NotesListAdapter.kt

@@ -206,16 +230,45 @@ class NotesListAdapter(
        notifyDataSetChanged()
    }

-    fun getNotes(): List<Note> {
+    fun getNotes(): MutableList<Note> {


Why do we need mutable list here? We expect this list to change only within this class to have single source of truth

shubertm · 2024-11-14T05:04:42Z

app/src/main/java/dev/arkbuilders/arkmemo/ui/adapters/NotesListAdapter.kt

+    var onItemLongPressed: ((pos: Int, note: Note) -> Unit)? = null
+    var onItemClicked: (() -> Unit)? = null
+
+    private val selectedNoteCount by lazy { MutableLiveData<Int>() }


Suggested change

private val selectedNoteCount by lazy { MutableLiveData<Int>() }

private val selectedNotesCount by lazy { MutableLiveData<Int>() }

shubertm · 2024-11-14T05:05:49Z

app/src/main/java/dev/arkbuilders/arkmemo/ui/adapters/NotesListAdapter.kt

+    var onItemClicked: (() -> Unit)? = null
+
+    private val selectedNoteCount by lazy { MutableLiveData<Int>() }
+    val observableSelectedNoteCount by lazy { selectedNoteCount }


Suggested change

val observableSelectedNoteCount by lazy { selectedNoteCount }

val observableSelectedNotesCount by lazy { selectedNoteCount }

shubertm · 2024-11-14T05:28:39Z

app/src/main/java/dev/arkbuilders/arkmemo/ui/viewmodels/NotesViewModel.kt

            viewModelScope.launch(iODispatcher) {
                notes.value = textNotesRepo.read() + graphicNotesRepo.read() + voiceNotesRepo.read()
                notes.value.let {
                    withContext(Dispatchers.Main) {
-                        onSuccess(it.sortedByDescending { note -> note.resource?.modified })
+                        notes.value = it.sortedByDescending { note -> note.resource?.modified }
+                        onSuccess(notes.value.toMutableList())


No need to pass MutableList here. We should not be passing mutable variable to other object unless specified

shubertm · 2024-11-14T05:34:39Z

app/src/main/java/dev/arkbuilders/arkmemo/ui/viewmodels/NotesViewModel.kt

-            note: Note,
-            onSuccess: () -> Unit,
+            notes: List<Note>,
+            onSuccess: (newList: MutableList<Note>) -> Unit,


Suggested change

onSuccess: (newList: MutableList<Note>) -> Unit,

onSuccess: (newList: List<Note>) -> Unit,

shubertm · 2024-11-14T05:47:39Z

app/src/main/java/dev/arkbuilders/arkmemo/ui/viewmodels/NotesViewModel.kt

                }
-
                [email protected] =
                    [email protected]()


shubertm · 2024-11-14T05:48:07Z

app/src/main/java/dev/arkbuilders/arkmemo/ui/viewmodels/NotesViewModel.kt

                withContext(Dispatchers.Main) {
-                    onSuccess.invoke()
+                    onSuccess.invoke([email protected]())


But this is not needed, I mean [email protected]()

shubertm · 2024-11-14T06:01:46Z

SVID_20241114_062853_1.mp4

Ripple goes below extra view on notes with previews. In other versions it is ok

#47

…tes are reloaded

* Long pressing on an item should also select it * Navigating back while in action mode should destroy it first * Update ripple effect for note item

* Fix a bug in selecting notes for deletion logic

tuancoltech · 2024-11-18T01:38:22Z

SVID_20241114_062853_1.mp4

Ripple goes below extra view on notes with previews. In other versions it is ok

@shubertm I haven't been clear what the issue is.
Do you mean, the ripple is partially below the graphic thumb, while it should be on top of it?

tuancoltech added enhancement New feature or request feature do not merge labels Aug 4, 2024

tuancoltech self-assigned this Aug 4, 2024

tuancoltech force-pushed the feat/support_batch_deletion_v2 branch 4 times, most recently from a49cb91 to 5cecfff Compare August 4, 2024 15:06

tuancoltech mentioned this pull request Aug 4, 2024

WIP: Support batch deletion in Memo app #56

Closed

tuancoltech force-pushed the feat/support_batch_deletion_v2 branch 2 times, most recently from c4c3c8c to 6342290 Compare August 8, 2024 15:07

tuancoltech force-pushed the feature/new_ui_design branch from d58496a to 5419bb4 Compare August 11, 2024 15:20

tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from 6342290 to a3266d3 Compare September 3, 2024 05:21

tuancoltech force-pushed the feature/new_ui_design branch 2 times, most recently from 90410db to 8df7cee Compare September 9, 2024 05:52

tuancoltech force-pushed the feat/support_batch_deletion_v2 branch 3 times, most recently from 4752e78 to c0ec632 Compare September 21, 2024 03:15

tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from c0ec632 to 524cbce Compare September 27, 2024 05:33

tuancoltech force-pushed the feat/support_batch_deletion_v2 branch 2 times, most recently from 10c794a to c0d8998 Compare October 9, 2024 14:44

shubertm self-requested a review October 22, 2024 11:03

shubertm requested changes Oct 22, 2024

View reviewed changes

tuancoltech changed the base branch from feature/new_ui_design to main October 25, 2024 05:38

tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from c0d8998 to 78aa757 Compare October 25, 2024 05:41

tuancoltech temporarily deployed to Development October 25, 2024 05:41 — with GitHub Actions Inactive

tuancoltech temporarily deployed to Development October 26, 2024 15:37 — with GitHub Actions Inactive

tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from c0ef5dd to b85a4ac Compare October 26, 2024 15:47

tuancoltech temporarily deployed to Development October 26, 2024 15:47 — with GitHub Actions Inactive

tuancoltech changed the title ~~WIP: Support batch deletion~~ Support batch deletion Oct 26, 2024

tuancoltech temporarily deployed to Development November 10, 2024 09:05 — with GitHub Actions Inactive

tuancoltech temporarily deployed to Development November 10, 2024 09:07 — with GitHub Actions Inactive

shubertm requested changes Nov 12, 2024

View reviewed changes

tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from 1723e15 to 5aef805 Compare November 13, 2024 14:27

tuancoltech temporarily deployed to Development November 13, 2024 14:27 — with GitHub Actions Inactive

tuancoltech requested a review from shubertm November 13, 2024 14:27

tuancoltech temporarily deployed to Development November 13, 2024 14:31 — with GitHub Actions Inactive

shubertm requested changes Nov 14, 2024

View reviewed changes

tuancoltech added 6 commits November 15, 2024 12:47

Support batch deletion in Memo app:

f3e025d

#47

Deleted notes are not removed from NoteAdapter's backed data until no…

363c3fb

…tes are reloaded

* Do not destroy action mode if app goes to background

38f1a29

* Long pressing on an item should also select it * Navigating back while in action mode should destroy it first * Update ripple effect for note item

Refresh selected note count text when a note is deleted in action mode

bf335b8

Clicking on a note item in selection mode should toggle the checkbox

1803fad

* Show empty state of notes list when all notes are deleted

4775613

* Fix a bug in selecting notes for deletion logic

tuancoltech force-pushed the feat/support_batch_deletion_v2 branch from 5aef805 to 4775613 Compare November 15, 2024 05:49

tuancoltech temporarily deployed to Development November 15, 2024 05:49 — with GitHub Actions Inactive

tuancoltech temporarily deployed to Development November 15, 2024 05:52 — with GitHub Actions Inactive

shubertm closed this Nov 15, 2024

shubertm deleted the feat/support_batch_deletion_v2 branch November 15, 2024 16:53

shubertm restored the feat/support_batch_deletion_v2 branch November 15, 2024 16:54

shubertm reopened this Nov 15, 2024

shubertm temporarily deployed to Development November 15, 2024 17:01 — with GitHub Actions Inactive

shubertm deployed to Development November 15, 2024 17:05 — with GitHub Actions Active

shubertm temporarily deployed to Development November 15, 2024 17:05 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support batch deletion #70

Support batch deletion #70

tuancoltech commented Aug 4, 2024 •

edited

Loading

shubertm left a comment •

edited

Loading

tuancoltech commented Nov 10, 2024

shubertm Nov 12, 2024

shubertm Nov 12, 2024

tuancoltech Nov 13, 2024

shubertm left a comment

shubertm Nov 14, 2024

shubertm Nov 14, 2024

shubertm Nov 14, 2024

shubertm Nov 14, 2024

shubertm Nov 14, 2024

shubertm Nov 14, 2024

shubertm Nov 14, 2024 •

edited

Loading

shubertm commented Nov 14, 2024

tuancoltech commented Nov 18, 2024

	suspend fun deleteNote(notes: List<Note>): Unit =
	suspend fun deleteNotes(notes: List<Note>): Unit =

	val selectedNotedForDelete = mutableListOf<Note>()
	val selectedNotesForDelete = mutableListOf<Note>()

	private val selectedNoteCount by lazy { MutableLiveData<Int>() }
	private val selectedNotesCount by lazy { MutableLiveData<Int>() }

	val observableSelectedNoteCount by lazy { selectedNoteCount }
	val observableSelectedNotesCount by lazy { selectedNoteCount }

	onSuccess: (newList: MutableList<Note>) -> Unit,
	onSuccess: (newList: List<Note>) -> Unit,

Support batch deletion #70

Are you sure you want to change the base?

Support batch deletion #70

Conversation

tuancoltech commented Aug 4, 2024 • edited Loading

Description:

Screenshots:

shubertm left a comment • edited Loading

Choose a reason for hiding this comment

tuancoltech commented Nov 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shubertm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shubertm Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

shubertm commented Nov 14, 2024

tuancoltech commented Nov 18, 2024

tuancoltech commented Aug 4, 2024 •

edited

Loading

shubertm left a comment •

edited

Loading

shubertm Nov 14, 2024 •

edited

Loading