Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Extracting most UI state to EditingState #126

Merged
merged 53 commits into from
Nov 13, 2024
Merged

Refactor: Extracting most UI state to EditingState #126

merged 53 commits into from
Nov 13, 2024

Commits on Nov 1, 2023

  1. First iteration of refactoring

    @isakovch @kirillt
    isakovch authored and kirillt committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    68a146e View commit details
    Browse the repository at this point in the history

  2. - Revert gradle.properties, since CI/CD is not support cache. CI/CD w… 

    …ill be fixed later
    @isakovch @kirillt
    isakovch authored and kirillt committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    71b2147 View commit details
    Browse the repository at this point in the history

  3. NO-TICKET - Ktlint fixes

    @isakovch @kirillt
    isakovch authored and kirillt committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    0b56a78 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Fix NoBeanDefFoundException in EditModule + add ktlint gradle plugin … 

    …+ update AGP
    @shubertm @kirillt
    shubertm authored and kirillt committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    7e9b537 View commit details
    Browse the repository at this point in the history

  2. Update workflow to JDK 17

    @shubertm @kirillt
    shubertm authored and kirillt committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    b8df169 View commit details
    Browse the repository at this point in the history

  3. Remove ktlint gradle plugin and add ktlintCheck to ktlint.gradle

    @shubertm @kirillt
    shubertm authored and kirillt committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    fa814c4 View commit details
    Browse the repository at this point in the history

  4. Run ktlintCheck after ktlintFormat

    @shubertm
    shubertm committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8244fce View commit details
    Browse the repository at this point in the history

  5. Remove context from shareImage

    @shubertm
    shubertm committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    b2b9f31 View commit details
    Browse the repository at this point in the history

  6. Delete getCachedImageUri

    @shubertm
    shubertm committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    7178dbb View commit details
    Browse the repository at this point in the history

  7. Extract image loading from EditViewModel file

    @shubertm
    shubertm committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6eba793 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. #97: Complete refactoring with best practices (#105) 

    * Remove context from shareImage
* Delete getCachedImageUri
* Extract image loading from EditViewModel file
* Move all state to EditingState
* Clarify Serialization in ImageDefaults
* Fix Share
    @shubertm
    shubertm authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    efe609b View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Merge remote-tracking branch 'origin/develop' into develop 

    # Conflicts:
#	.scripts/ktlint.gradle
#	app/src/main/java/dev/arkbuilders/arkretouch/editing/ui/main/EditScreen.kt
#	app/src/main/java/dev/arkbuilders/arkretouch/editing/ui/main/EditViewModel.kt
#	app/src/main/java/dev/arkbuilders/arkretouch/utils/ImageLoading.kt
    @shubertm
    shubertm committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    2f607b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Refactor packages structure

    @shubertm
    shubertm committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    ff0292e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. Merge branch 'main' into develop 

    # Conflicts:
#	.gitignore
#	app/build.gradle
#	app/src/main/java/dev/arkbuilders/arkretouch/presentation/dialogs/SavePathDialog.kt
#	app/src/main/java/dev/arkbuilders/arkretouch/presentation/screens/EditScreen.kt
#	app/src/main/java/dev/arkbuilders/arkretouch/presentation/viewmodels/EditViewModel.kt
#	app/src/main/java/dev/arkbuilders/arkretouch/utils/Utils.kt
#	build.gradle
#	gradle/wrapper/gradle-wrapper.properties
    @shubertm
    shubertm committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    1429d2c View commit details
    Browse the repository at this point in the history

  2. Resolve conflicts

    @shubertm
    shubertm committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    85f3a47 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Refactor: Extract crop mode to EditingState (#125) 

    * Extract crop mode to editing state

* Remove crop mode from EditManager
    @shubertm
    shubertm authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    6e65ad2 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Extract isRotateMode to editingState

    @shubertm
    shubertm committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ec87906 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Extract isRotateMode to editingState

    @shubertm
    shubertm committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    cb936fe View commit details
    Browse the repository at this point in the history

  2. Extract isRotateMode to editingState

    @shubertm
    shubertm committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    4d3089a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Extract isResizeMode to editingState

    @shubertm
    shubertm committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7e34760 View commit details
    Browse the repository at this point in the history

  2. Extract isResizeMode to editingState

    @shubertm
    shubertm committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    531e856 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Extract isEraseMode to EditingState

    @shubertm
    shubertm committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8d33c15 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Extract isEraseMode to EditingState

    @shubertm
    shubertm committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e69f739 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Extract isZoomMode + isPanMode to EditingState

    @shubertm
    shubertm committed May 9, 2024
    Configuration menu
    Copy the full SHA
    1d22478 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Extract isBlurMode to EditingState

    @shubertm
    shubertm committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    89768f1 View commit details
    Browse the repository at this point in the history

  2. Extract isBlurMode to EditingState

    @shubertm
    shubertm committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    76eef62 View commit details
    Browse the repository at this point in the history

  3. Extract isBlurMode to EditingState d

    @shubertm
    shubertm committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    659edee View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Fix resize operation

    @shubertm
    shubertm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c8913dc View commit details
    Browse the repository at this point in the history

  2. Extract isEyeDropperMode to EditingState

    @shubertm
    shubertm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b79c800 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Extract canUndo and canRedo to EditingState

    @shubertm
    shubertm committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6a8e5cd View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Clean up

    @shubertm
    shubertm committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f1d4c61 View commit details
    Browse the repository at this point in the history

  2. Clean up

    @shubertm
    shubertm committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    cab01b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Remove commented out code

    @shubertm
    shubertm committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9f3eee4 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Move all toggleCrop logic from EditScreen to EditViewModel

    @shubertm
    shubertm committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    7e2d5bf View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Move operations logic from EditScreen to EditViewModel

    @shubertm
    shubertm committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ad36a3c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Fix lint + remove redundant permission requests

    @shubertm
    shubertm committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6fdb288 View commit details
    Browse the repository at this point in the history

  2. Fix lint + remove redundant permission requests

    @shubertm
    shubertm committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    1d4c825 View commit details
    Browse the repository at this point in the history

  3. Check lint failure cause

    @shubertm
    shubertm committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    633fba1 View commit details
    Browse the repository at this point in the history

  4. Check lint failure cause

    @shubertm
    shubertm committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2682f02 View commit details
    Browse the repository at this point in the history

  5. Fix lint

    @shubertm
    shubertm committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    4216f58 View commit details
    Browse the repository at this point in the history

  6. Fix lint

    @shubertm
    shubertm committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    99e0dc2 View commit details
    Browse the repository at this point in the history

  7. Update compose to 1.6.8

    @shubertm
    shubertm committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    4b2a12c View commit details
    Browse the repository at this point in the history

  8. Update compose to 1.6.8

    @shubertm
    shubertm committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    91ee12c View commit details
    Browse the repository at this point in the history

  9. Fix lint

    @shubertm
    shubertm committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    3d873a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Fix lint

    @shubertm
    shubertm committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    36aa214 View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @shubertm
    shubertm committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    861b1c9 View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @shubertm
    shubertm committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ffb97bd View commit details
    Browse the repository at this point in the history

  4. Update workflow

    @shubertm
    shubertm committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    570808e View commit details
    Browse the repository at this point in the history

  5. Update workflows

    @shubertm
    shubertm committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3813f97 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Update gradle

    @shubertm
    shubertm committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    2a93baf View commit details
    Browse the repository at this point in the history

  2. Fix SavePathDialog

    @shubertm
    shubertm committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    68a1a73 View commit details
    Browse the repository at this point in the history

  3. Fix sharing image

    @shubertm
    shubertm committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    7e24ab3 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Minor refactors

    @shubertm
    shubertm committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9962dc1 View commit details
    Browse the repository at this point in the history